Remove UnsafeFeatures as we decided the top level guard is not useful #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
|
bors r+ |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
914: Change the texture sample type for the cube example from Float to Uint r=kvark a=igowen this is a rework of gfx-rs#764. i think wgpu supports everything we need for this now! Co-authored-by: Ian Gowen <ian@gowen.cc>
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
…tions (gfx-rs#764) * [msl-out] wrap arrays in structs so that they can be returned by functions * Fix clippy problems * use a raw array for output fields * Fix clippy problems * Apply suggestions * Remove put_initialization_component * Check if the array is a constant size * Don't use the pointer class
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Assigning arrays by value works fine since all arrays are now wrapped by a struct. Co-authored-by: teoxoy <28601907+teoxoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Reverts part of #691 about unsafe extensions
Description
Top-level unsafe is not sound. We still need unsafety close to the spot where it's triggered.
Testing
untested