-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winit 0.27 Update and raw-window-handle 0.5 #2918
Conversation
Tested on Fedora /
|
This bug will be fixed in rust-lang/rust#97791 that comes in 1.63 |
So this would bump our MSRV to 1.63? |
Apparently so. |
Could you have this PR bump the MSRV? |
winit 0.27.1 has been released which lowers the MSRV to |
This reverts commit 40d91e9.
Alright all builds were able to run https://github.com/wyatt-herkamp/wgpu/actions/runs/2774303424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Enscripten CI is mad |
It doesn't like importing |
🥳 Question: what is the release schedule for wgpu? i.e. when can I expect this to be released? |
Currently we're on a loose 90 day schedule, without making up for lost time so next release will be late September - the calculated date is listed on the milestone for 0.14 |
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Closes #2928
Description
Winit released 0.27 today. With this decoupling Display and Window Handles rust-windowing/raw-window-handle#92
If I am within the Window Handle match block I get the Display handle via an if let statement returning with an Error if the type does not match.
Testing
Ran the examples on a Windows 11 environment x86 AMD/Nvidia setup