-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winit 0.27 update #5347
Winit 0.27 update #5347
Conversation
winit 0.27 has been released but this is still blocked on wgpu updating its raw-window-handle dep here: gfx-rs/wgpu#2918 |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
crates/bevy_winit/Cargo.toml
Outdated
winit = { version = "0.27", default-features = false } | ||
approx = { version = "0.5", default-features = false } | ||
raw-window-handle = "0.5" | ||
|
||
[target.'cfg(target_arch = "wasm32")'.dependencies] | ||
winit = { version = "0.26.0", default-features = false } | ||
winit = { version = "0.27", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is winit duplicated here?
As wasm doesn't add any new features, the duplicate entry should just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not entirely sure... I'll remove it unless anyone has any concerns about it.
Do note that because of it being a public dependency wgpu cannot release a patch to rwh 0.5, so this will have to wait till wgpu 0.14 in late september. |
@cwfitzgerald No worries, this missed the bevy 0.8 release anyways and late september still falls solidly into the bevy 0.9 release window I think. |
Could you also update |
By the way, updating ndk glue to 0.7 would (probably) not resolve #3648, since cpal still uses 0.6. |
@harudagondi I'll put in a quick PR to them to update to 0.7 so we can fix both of em. |
@Aceeri What is the status of this? Still blocked? |
Ya this will prob be blocked for another month or so for wgpu stuff. We could use a git revision if we wanted in the mean time I suppose |
For visibility, here's another update attempt: #6086 |
@Aceeri any chance you can pick up the updates soon? |
@mockersf Ya, been just a bit tied up in trying to get spring forces that don't become unstable with bad user inputs but I'll work on gettin this back into shape this week. |
Closing in favor of #6218, which is nearly ready to merge :) Thanks for scouting this out! |
Objective
This is just a pre-emptive PR for the next winit versionSolution
Changelog
cursor_locked
tocursor_grab_mode
and created aCursorGrabMode
enum similar to winit's.Migration Guide
true
/false
ofWindowDescriptor
s for cursor_locked toCursorGrabMode::Locked
.Could add this is we want