-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update winit version 0.27.3 #6086
Conversation
ar37-rs
commented
Sep 24, 2022
- Recent winit (version 0.27.3) also has compat for raw-window-handle 0.4.2
- Tested on desktop, native and wasm
There is already a previous PR (#5347) that updates winit (and other dependencies). Afaik this is blocked on wgpu. |
@harudagondi, it's winit 0.27.3 (not < than that), working fine i've tested both native including mouse_grab example and other on wasm as well. |
not sure for android though, since we are waiting winit 0.28.0 for more compact android support like: https://github.com/rib/android-activity |
It's |
@harudagondi the problem wgpu blocked was on winit 0.27.2 which has raw-window-handle 4.2 compat problem, already fixed on 0.27.3 |
Hmm. I'll admit I have minimal knowledge on rendering, but in that PR |
Update for grab mode seems better in #5347. This update would also need to update wgpu update should be within the week, let's wait for it. |
@mockersf agree on that. |
Closing in favor of #6218, which is nearly ready to merge :) Thanks for scouting this out! |