Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit version 0.27.3 #6086

Closed
wants to merge 2 commits into from
Closed

Update winit version 0.27.3 #6086

wants to merge 2 commits into from

Conversation

ar37-rs
Copy link

@ar37-rs ar37-rs commented Sep 24, 2022

  • Recent winit (version 0.27.3) also has compat for raw-window-handle 0.4.2
  • Tested on desktop, native and wasm

@harudagondi
Copy link
Member

There is already a previous PR (#5347) that updates winit (and other dependencies). Afaik this is blocked on wgpu.

@ar37-rs
Copy link
Author

ar37-rs commented Sep 24, 2022

@harudagondi, it's winit 0.27.3 (not < than that), working fine i've tested both native including mouse_grab example and other on wasm as well.

@ar37-rs
Copy link
Author

ar37-rs commented Sep 24, 2022

not sure for android though, since we are waiting winit 0.28.0 for more compact android support like: https://github.com/rib/android-activity

@harudagondi
Copy link
Member

harudagondi commented Sep 24, 2022

It's winit = 0.27, which means >=0.27.0, <0.28.0, so it would pick 0.27.3. Also as far as I understand, this PR have not updated ndk-glue to 0.7. #5347 has already changed its dependencies for android.

@ar37-rs
Copy link
Author

ar37-rs commented Sep 24, 2022

@harudagondi the problem wgpu blocked was on winit 0.27.2 which has raw-window-handle 4.2 compat problem, already fixed on 0.27.3

@harudagondi
Copy link
Member

Hmm. I'll admit I have minimal knowledge on rendering, but in that PR raw-window-handle is changed to 0.5. Maybe we should ask why it is that case.

@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on labels Sep 24, 2022
@mockersf
Copy link
Member

Update for grab mode seems better in #5347. This update would also need to update ndk-glue. I don't know about raw-window-handle though.

wgpu update should be within the week, let's wait for it.

@ar37-rs ar37-rs marked this pull request as draft September 25, 2022 02:27
@ar37-rs
Copy link
Author

ar37-rs commented Sep 25, 2022

@mockersf agree on that.

@alice-i-cecile
Copy link
Member

Closing in favor of #6218, which is nearly ready to merge :) Thanks for scouting this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants