Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit requirement from 0.26.0 to 0.27.2 #5701

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2022

Updates the requirements on winit to permit the latest version.

Release notes

Sourced from winit's releases.

Winit Version v0.27.2

  • On macOS, fixed touch phase reporting when scrolling.
  • On X11, fix min, max and resize increment hints not persisting for resizable windows (e.g. on DPI change).
  • On Windows, respect min/max inner sizes when creating the window.
  • For backwards compatibility, Window now (additionally) implements the old version (0.4) of the HasRawWindowHandle trait
  • On Windows, added support for EventLoopWindowTarget::set_device_event_filter.
  • On Wayland, fix user requested WindowEvent::RedrawRequested being delayed by a frame.
Changelog

Sourced from winit's changelog.

0.27.2 (2022-8-12)

  • On macOS, fixed touch phase reporting when scrolling.
  • On X11, fix min, max and resize increment hints not persisting for resizable windows (e.g. on DPI change).
  • On Windows, respect min/max inner sizes when creating the window.
  • For backwards compatibility, Window now (additionally) implements the old version (0.4) of the HasRawWindowHandle trait
  • On Windows, added support for EventLoopWindowTarget::set_device_event_filter.
  • On Wayland, fix user requested WindowEvent::RedrawRequested being delayed by a frame.

0.27.1 (2022-07-30)

  • The minimum supported Rust version was lowered to 1.57.0 and now explicitly tested.
  • On X11, fix crash on start due to inability to create an IME context without any preedit.

0.27.0 (2022-07-26)

  • On Windows, fix hiding a maximized window.
  • On Android, ndk-glue's NativeWindow lock is now held between Event::Resumed and Event::Suspended.
  • On Web, added EventLoopExtWebSys with a spawn method to start the event loop without throwing an exception.
  • Added WindowEvent::Occluded(bool), currently implemented on macOS and X11.
  • On X11, fix events for caps lock key not being sent
  • Build docs on docs.rs for iOS and Android as well.
  • Breaking: Removed the WindowAttributes struct, since all its functionality is accessible from WindowBuilder.
  • Added WindowBuilder::transparent getter to check if the user set transparent attribute.
  • On macOS, Fix emitting Event::LoopDestroyed on CMD+Q.
  • On macOS, fixed an issue where having multiple windows would prevent run_return from ever returning.
  • On Wayland, fix bug where the cursor wouldn't hide in GNOME.
  • On macOS, Windows, and Wayland, add set_cursor_hittest to let the window ignore mouse events.
  • On Windows, added WindowExtWindows::set_skip_taskbar and WindowBuilderExtWindows::with_skip_taskbar.
  • On Windows, added EventLoopBuilderExtWindows::with_msg_hook.
  • On Windows, remove internally unique DC per window.
  • On macOS, remove the need to call set_ime_position after moving the window.
  • Added Window::is_visible.
  • Added Window::is_resizable.
  • Added Window::is_decorated.
  • On X11, fix for repeated event loop iteration when ControlFlow was Wait
  • On X11, fix scale factor calculation when the only monitor is reconnected
  • On Wayland, report unaccelerated mouse deltas in DeviceEvent::MouseMotion.
  • On Web, a focused event is manually generated when a click occurs to emulate behaviour of other backends.
  • Breaking: Bump ndk version to 0.6, ndk-sys to v0.3, ndk-glue to 0.6.
  • Remove no longer needed WINIT_LINK_COLORSYNC environment variable.
  • Breaking: Rename the Exit variant of ControlFlow to ExitWithCode, which holds a value to control the exit code after running. Add an Exit constant which aliases to ExitWithCode(0) instead to avoid major breakage. This shouldn't affect most existing programs.
  • Add EventLoopBuilder, which allows you to create and tweak the settings of an event loop before creating it.
  • Deprecated EventLoop::with_user_event; use EventLoopBuilder::with_user_event instead.
  • Breaking: Replaced EventLoopExtMacOS with EventLoopBuilderExtMacOS (which also has renamed methods).
  • Breaking: Replaced EventLoopExtWindows with EventLoopBuilderExtWindows (which also has renamed methods).
  • Breaking: Replaced EventLoopExtUnix with EventLoopBuilderExtUnix (which also has renamed methods).
  • Breaking: The platform specific extensions for Windows winit::platform::windows have changed. All HANDLE-like types e.g. HWND and HMENU were converted from winapi types or *mut c_void to isize. This was done to be consistent with the type definitions in windows-sys and to not expose internal dependencies.
  • The internal bindings to the Windows API were changed from the unofficial winapi bindings to the official Microsoft windows-sys bindings.
  • On Wayland, fix polling during consecutive EventLoop::run_return invocations.

... (truncated)

Commits
  • 2e4338b Release 0.27.2 version
  • ec2888b On Wayland, fix Window::request_redraw being delayed
  • fa83bac Remove redundant steps from CI
  • ee7dc48 Fix missleading breaking change on Windows
  • 11d4a30 Implement version 0.4 of the HasRawWindowHandle trait
  • ad41eaf Add CODEOWNERS file (#2420)
  • 9b71df9 On Windows, add opt-in function for device events (#2409)
  • b1c9e4a Fix tracking of phase changes for mousewheel on trackpad (#2158)
  • cdbaf48 On X11, fix window hints not persisting
  • 6b7ceed Windows: respect min/max sizes when creating the window (#2393)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [winit](https://github.com/rust-windowing/winit) to permit the latest version.
- [Release notes](https://github.com/rust-windowing/winit/releases)
- [Changelog](https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md)
- [Commits](rust-windowing/winit@v0.26.0...v0.27.2)

---
updated-dependencies:
- dependency-name: winit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Aug 15, 2022
@cart cart added the S-Blocked This cannot move forward until something else changes label Aug 30, 2022
@cart
Copy link
Member

cart commented Aug 30, 2022

This is blocked on wgpu releasing a version that depends on winit 0.27 (it has been updated on their main branch).

@mockersf
Copy link
Member

#5347 will do this update with the changed needed

@mockersf mockersf closed this Aug 30, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/winit-0.27.2 branch August 30, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants