Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow gles float textures to be multisampled if available #3183

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 7, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
n/a

Description
Couldn't find any restrictions on render target use for enabled float textures on GLES. It seems MSAA use works just fine iff the respective float extensions are enabled.

Testing
Tested rendering to a RGBA32f and RGBA16f target on WebGl. Did not check on resolve

wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf requested a review from cwfitzgerald November 19, 2022 18:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #3183 (7de72e3) into master (04d12ba) will decrease coverage by 0.07%.
The diff coverage is 62.22%.

@@            Coverage Diff             @@
##           master    #3183      +/-   ##
==========================================
- Coverage   64.70%   64.62%   -0.08%     
==========================================
  Files          81       81              
  Lines       38819    39485     +666     
==========================================
+ Hits        25118    25518     +400     
- Misses      13701    13967     +266     
Impacted Files Coverage Δ
player/src/lib.rs 53.31% <ø> (ø)
wgpu-core/src/id.rs 81.25% <0.00%> (-2.63%) ⬇️
wgpu-core/src/lib.rs 96.55% <ø> (ø)
wgpu-core/src/present.rs 0.00% <0.00%> (ø)
wgpu-core/src/resource.rs 25.13% <ø> (ø)
wgpu-hal/src/dx11/device.rs 0.00% <0.00%> (ø)
wgpu-hal/src/empty.rs 0.00% <ø> (ø)
wgpu-hal/src/lib.rs 26.21% <ø> (ø)
wgpu/src/backend/direct.rs 54.80% <0.00%> (-0.30%) ⬇️
wgpu/src/lib.rs 50.33% <0.00%> (-2.49%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Wumpf
Copy link
Member Author

Wumpf commented Nov 23, 2022

@cwfitzgerald bump :)

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party

@cwfitzgerald cwfitzgerald merged commit 2ccfb42 into gfx-rs:master Nov 23, 2022
@Wumpf Wumpf deleted the fix-gl-msaa-float branch November 24, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants