Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RenderPass related errors #3549

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Mar 1, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Reworks how various renderpass related errors work to be significantly more informative.

All commits standalone, I encorage rebase-merging

@cwfitzgerald cwfitzgerald requested a review from teoxoy March 2, 2023 17:40
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few wording suggestions.

wgpu-core/src/resource.rs Outdated Show resolved Hide resolved
wgpu-core/src/resource.rs Outdated Show resolved Hide resolved
wgpu-core/src/device/mod.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (rebase) March 2, 2023 23:38
@cwfitzgerald cwfitzgerald disabled auto-merge March 2, 2023 23:38
@cwfitzgerald
Copy link
Member Author

CI got royally screwed up here due to the actions outage - I'm going to override merge and then deal with the consequences

@cwfitzgerald cwfitzgerald merged commit db3be88 into gfx-rs:master Mar 3, 2023
@cwfitzgerald cwfitzgerald deleted the error-improvements branch March 3, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain “texture view is not renderable” error Renderpass Compatibility Errors Are Missing Context
2 participants