Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for I64 and I64 image atomics #5123

Closed
wants to merge 13 commits into from
Closed

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jan 23, 2024

Connections
Implements #5009

Description
Add support for U64/I64 types in shaders, and atomic operations on storage_texture<u64/i64> from within compute shaders.

Testing
TODO

TODO

  • Support for R64Uint/R64Sint textures
  • Naga frontend + validation for atomic ops on storage textures
  • Tests

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@JMS55 JMS55 requested review from a team as code owners January 23, 2024 05:48
@JMS55 JMS55 marked this pull request as draft January 23, 2024 05:48
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking changes to get this out of my review queue. Please dismiss this review before marking as ready-to-review.

@atlv24 atlv24 mentioned this pull request Mar 13, 2024
6 tasks
@atlv24 atlv24 mentioned this pull request Apr 15, 2024
6 tasks
@cwfitzgerald
Copy link
Member

Closing in favor of #5537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants