Disable GPU based validation in tests by default but keep it on CI #5269
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's pull it everywhere - #5154 is having issues with dx12 GBV, and it's already been taking way too long. The failures you're getting now is because we're now missing the additional validation errors when GBV is enabled. |
|
Tried a different strategy in #5271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With gpu based validation,
cargo xtask testimmediately fills all of my RAM and makes the desktop unusable (forcing me to hard-reboot the computer) on the two computers I have handy (they have 32 and 64 GB of RAM).I don't know if it's a mesa or AMD specific thing but it's so disruptive that I think that we need to take a more careful approach to enabling the the advanced validation stuff. This PR turns it off by default for people running tests locally (can be re-enabled using the
WGPU_GPU_BASED_VALIDATIONenvironment variable), but leaves it enabled on CI for now.Checklist
cargo fmt.cargo clippy.