-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenGL support for TEXTURE_FORMAT_16BIT_NORM on supported versions #5330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good except issue with incorrectly flagging it as es supported I believe.
Otherwise, please add a changelog entry. Thank you!
a34dbdf
to
4e58461
Compare
Thanks, resolved your code comment! |
I am unsure if I should enable Rgba16Snorm, since I have not tested it. Please let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thank you!
Let's not enable it unless we know it really works :)
Let's not merge this PR until I have confirmed it's working. I'll try to work on it asap. |
I think this was merged by mistake? Should probably be reverted. |
ah sorry, my bad. Will check on this tomorrow |
… versions (gfx-rs#5330)" This reverts commit 352cb3d.
Description
When handing wgpu an OpenGL context that has support for
TEXTURE_FORMAT_16BIT_NORM
, it was previously ignored. I have tried to add support forTEXTURE_FORMAT_16BIT_NORM
for OpenGL versions that support it.Testing
cargo xtask test
)Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.