Revert "Add OpenGL support for TEXTURE_FORMAT_16BIT_NORM on supported… #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions (gfx-rs#5330)" This reverts commit 352cb3d.
Wumpf
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
for posterity: we discussed this a bit on DM and it seems Rgba16SNorm seems to be never supported and it's unclear which OGL version (& hardware/driver) supports Rgba16UNorm. See https://docs.gl/gl4/glTexImage2D
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… versions (#5330)"
This reverts commit 352cb3d.
Connections
Description
The commit #5330 was mistakenly merged by @Wumpf before being fully tested by @bes.
Testing
After testing some more on my MR, I am mostly convinced that it should not have been merged, and that it is unnecessary. Please accept my apologies.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Addchange toCHANGELOG.md. See simple instructions inside file.