[wgpu-hal] #5956 windows-rs migration followups and cleanups
#6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Aug 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MarijnS95
commented
Aug 28, 2024
MarijnS95
force-pushed
the
windows-rs-clean
branch
2 times, most recently
from
e6fcdad
to
40ec498
Compare
teoxoy
reviewed
Aug 28, 2024
MarijnS95
force-pushed
the
windows-rs-clean
branch
from
40ec498
to
f50eaa5
Compare
|
The last remaining item seems to be #5956 (comment). |
|
@teoxoy the last I remember is that that was hard to do as Let me re-check what's possible nowadays. |
MarijnS95
force-pushed
the
windows-rs-clean
branch
from
f50eaa5
to
be2ec15
Compare
|
@teoxoy |
MarijnS95
commented
Aug 29, 2024
MarijnS95
force-pushed
the
windows-rs-clean
branch
from
be2ec15
to
12c8ecc
Compare
PR gfx-rs#5956 wasn't fully complete and still had some outstanding minor issues and cleanups to be done, as well as hidden semantic changes. This addresses a bunch of them: - Remove unnecessary `Error` mapping to `String` as `windows-rs`'s `Error` has a more complete `Display` representation by itself. - Remove `into_result()` as every call could have formatted the `windows-rs` `Error` in a log call directly. - Pass `None` instead of a pointer to an empty slice wherever possible (waiting for microsoft/win32metadata#1971 to trickle down into `windows-rs`). - Remove `.clone()` on COM objects (temporarily increasing the refcount) when it can be avoided by inverting the order of operations on `raw` variables.
MarijnS95
force-pushed
the
windows-rs-clean
branch
from
12c8ecc
to
14d4c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5956 wasn't fully complete and still had some outstanding minor issues and cleanups to be done, as well as hidden semantic changes. This addresses a bunch of them:
Errormapping toStringaswindows-rs'sErrorhas a more completeDisplayrepresentation by itself.into_result()as every call could have formatted thewindows-rsErrorin a log call directly.Noneinstead of a pointer to an empty slice wherever possible (waiting for MarkID3D12GraphicsCommandList::ClearDepthStencilViewpRectsasOptionalmicrosoft/win32metadata#1971 to trickle down intowindows-rs).ptr::null_mut(), which "fixes DX12 backend no longer works after #5956 #6162"..clone()on COM objects (temporarily increasing the refcount) when it can be avoided by inverting the order of operations onrawvariables.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.