Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrokeDashOffset does not work #230

Closed
VlaDi4eKK opened this issue Sep 26, 2019 · 2 comments
Closed

StrokeDashOffset does not work #230

VlaDi4eKK opened this issue Sep 26, 2019 · 2 comments
Assignees
Milestone

Comments

@VlaDi4eKK
Copy link

There is no prefix for LineDashOffset in the source code of the library. The new documentation mentions this style, but there is no implementation.

In general, I need to implement the direction of the route. Those. put arrows on the line so that you can understand the direction. The Dash mechanism suits me, but you cannot make your own drawing there for repetition. How to implement such a task?

@ghettovoice ghettovoice self-assigned this Sep 27, 2019
@ghettovoice
Copy link
Owner

ghettovoice commented Sep 27, 2019

Hello @VlaDi4eKK ,
I guess you talk about this style implementation in the lib https://github.com/ghettovoice/vuelayers/blob/master/src/ol-ext/style.js#L325.
So this is actually just a convenient wrapper around OpenLayers style objects.

While I fix this in this lib you can use OpenLayers styles directly.
Take a look here https://openlayers.org/en/latest/apidoc/module-ol_style_Style.html

Actually you can replace only stroke part of createStyle helper call and use all missed
ol/style/Stroke options:

import Stroke from 'ol/style/Stroke'

createStyle({
  // ...other styles: fill*, text*, ...
  // replace all stroke* props with one already initialized Stroke object
  stroke: new Stroke({ ... })
})

Or fully replace usage of style helpers from vuelayers/lib/ol-ext with OpenLayers objects.

@ghettovoice ghettovoice added this to the v0.11.5 milestone Sep 27, 2019
@VlaDi4eKK
Copy link
Author

Thanks for the answer! I decided to do it differently. Since you cannot use your symbol for use in StrokeDash (for example, ↓), you had to rewrite the algorithm differently and just add a new layer with arrows on top of the path.

ghettovoice added a commit that referenced this issue Sep 27, 2019
- fix #132
- fix #224
- fix #225
- fix #226
- fix #230
ghettovoice added a commit that referenced this issue Oct 3, 2019
- resolved #132 #224 #225 #226, #230
- simplified initial interaction/controls setup #95
- added `id` property for all ol components for easy identification
- mixins, ol-ext and rx-ext now are build to single file package,
  imports from those packages are not changed
- UMD version (dev/demo version) now includes all used stuff from `ol`
  package
ghettovoice added a commit that referenced this issue Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230
- merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208,
  #212, #213, #215, #221, #227, #231
  Thanks to @baspeeters, @sjmallon, @janlazo, @categulario,
  @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange
- improved property watchers
- optional debug messages
- fixed broken UMD version
- simplified initial interaction/controls setup #95
- added `id` property for all ol components for easy identification
- mixins, ol-ext and rx-ext now are build to single file package,
  imports from those packages are not changed
- UMD version (dev/demo version) now includes all used stuff from `ol`
  package
- updated documentation and README
ghettovoice added a commit that referenced this issue Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230
- merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208,
  #212, #213, #215, #221, #227, #231
  Thanks to @baspeeters, @sjmallon, @janlazo, @categulario,
  @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange
- improved property watchers
- optional debug messages
- fixed broken UMD version
- simplified initial interaction/controls setup #95
- added `id` property for all ol components for easy identification
- mixins, ol-ext and rx-ext now are build to single file package,
  imports from those packages are not changed
- UMD version (dev/demo version) now includes all used stuff from `ol`
  package
- updated documentation and README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants