Add Youtube wall popup to v10 #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial @kalinme testing failed. |
smalluban
commented
Nov 20, 2023
| window.addEventListener('yt-navigate-start', () => closeIframe(), true); | ||
|
|
||
| detectWall(async () => { | ||
| if (await isFeatureDisabled()) return; |
There was a problem hiding this comment.
YT page is long living app, so the condition must be checked each time - not only at startup (applies to v8 & v10).
smalluban
force-pushed
the
fix-youtube-wall-popup
branch
from
66a6514 to
ec77e51
Compare
philipp-classen
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/uishowIframeto detect if the iframe is already showndetectWallfunctionThe current logic detects changes in the DOM and checks if the URL has changed. If so, selectors for the wall are checked if exists, and then we trigger showing up the iframe. As the iframe blocks displaying more than once, it triggers each time the selectors are found.
For the notice, Safari
chrome.windows.create()silently returns a resolved promise if the extension is not allowed in private mode. Thechrome.extension.inIncognitoContextalso always returnsfalse.