-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Youtube wall popup to v10 #1387
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,40 @@ | ||
/** | ||
* Ghostery Browser Extension | ||
* https://www.ghostery.com/ | ||
* | ||
* Copyright 2017-present Ghostery GmbH. All rights reserved. | ||
* | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0 | ||
*/ | ||
|
||
import detectWall from '@ghostery/ui/youtube/wall'; | ||
import { showIframe, closeIframe } from '@ghostery/ui/iframe'; | ||
|
||
// Based on https://github.com/AdguardTeam/AdguardFilters/blob/e5ae8e3194f8d18bdcc660d4c42282e4a96ca5b9/AnnoyancesFilter/Popups/sections/antiadblock.txt#L2044 | ||
const ADBLOCKER_WALL_SELECTORS = [ | ||
'ytd-watch-flexy:not([hidden]) ytd-enforcement-message-view-model > div.ytd-enforcement-message-view-model', | ||
]; | ||
function isFeatureDisabled() { | ||
return new Promise((resolve) => { | ||
chrome.storage.local.get(['youtube_dont_show_again'], (storage) => { | ||
resolve(storage.youtube_dont_show_again); | ||
}); | ||
}); | ||
} | ||
|
||
let isShown = false; | ||
if (!chrome.extension.inIncognitoContext) { | ||
(async () => { | ||
if (await isFeatureDisabled()) return; | ||
|
||
chrome.storage.local.get(['youtube_dont_show_again'], (storage) => { | ||
if (storage.youtube_dont_show_again || chrome.extension.inIncognitoContext) { | ||
return; | ||
} | ||
window.addEventListener('yt-navigate-start', () => { | ||
closeIframe(); | ||
}, true); | ||
|
||
window.addEventListener('yt-navigate-start', () => { | ||
isShown = false; | ||
closeIframe(); | ||
}, true); | ||
detectWall(async () => { | ||
if (await isFeatureDisabled()) return; | ||
|
||
setInterval(() => { | ||
if (!isShown && document.querySelectorAll(ADBLOCKER_WALL_SELECTORS).length > 0) { | ||
showIframe(chrome.runtime.getURL(`app/templates/youtube.html?url=${encodeURIComponent(window.location.href)}`), '460px'); | ||
isShown = true; | ||
} | ||
}, 2000); | ||
}); | ||
showIframe( | ||
chrome.runtime.getURL(`app/templates/youtube.html?url=${encodeURIComponent(window.location.href)}`), | ||
'460px', | ||
); | ||
}); | ||
})(); | ||
} |
112 changes: 0 additions & 112 deletions
112
extension-manifest-v2/app/youtube/components/message.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/** | ||
* Ghostery Browser Extension | ||
* https://www.ghostery.com/ | ||
* | ||
* Copyright 2017-present Ghostery GmbH. All rights reserved. | ||
* | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0 | ||
*/ | ||
|
||
import { showIframe, closeIframe } from '@ghostery/ui/iframe'; | ||
import detectWall from '@ghostery/ui/youtube/wall'; | ||
|
||
async function isFeatureDisabled() { | ||
const { options, youtubeDontAsk } = await chrome.storage.local.get([ | ||
'options', | ||
'youtubeDontAsk', | ||
]); | ||
|
||
if ( | ||
// User's choice to not show the wall | ||
youtubeDontAsk || | ||
// Terms not accepted or paused domain | ||
!options || | ||
!options.terms || | ||
options.paused.some(({ id }) => id.includes('youtube.com')) | ||
) { | ||
return true; | ||
} | ||
|
||
return false; | ||
} | ||
|
||
// INFO: Safari always returns false for `inIncognitoContext` | ||
if (!chrome.extension.inIncognitoContext) { | ||
(async () => { | ||
if (await isFeatureDisabled()) return; | ||
|
||
window.addEventListener('yt-navigate-start', () => closeIframe(), true); | ||
|
||
detectWall(async () => { | ||
if (await isFeatureDisabled()) return; | ||
|
||
showIframe( | ||
chrome.runtime.getURL( | ||
`/pages/youtube/index.html?url=${encodeURIComponent( | ||
window.location.href, | ||
)}`, | ||
), | ||
'460px', | ||
); | ||
}); | ||
})(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta name="viewport" content="width=device-width" /> | ||
<title>Youtube Wall</title> | ||
<script src="./index.js" type="module" async></script> | ||
</head> | ||
<body></body> | ||
</html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YT page is long living app, so the condition must be checked each time - not only at startup (applies to v8 & v10).