-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream update to v1.4.5 #77
Conversation
enum: | ||
- ServicePrincipal | ||
- UserAssignedMSI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts theoretical breaking change from previous minor version.
@@ -36,6 +36,21 @@ | |||
properties: | |||
dnsName: | |||
type: string | |||
ipTags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IP tags are optional, so vintage workload clusters are not affected.
@@ -137,6 +137,52 @@ | |||
image: | |||
description: Image is used to provide details of an image to use during VM creation. If image details are omitted the image will default the Azure Marketplace "capi" offer, which is based on Ubuntu. | |||
properties: | |||
computeGallery: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces now deprecated SharedGallery. Giant Swarm vintage workload clusters are not using these fields, so they are not affected with this change.
@@ -18,6 +18,13 @@ | |||
acceleratedNetworking: | |||
description: AcceleratedNetworking enables or disables Azure accelerated networking. If omitted, it will be set based on whether the requested VMSize supports accelerated networking. If AcceleratedNetworking is set to true with a VMSize that does not support it, Azure will return an error. | |||
type: boolean | |||
additionalCapabilities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New optional property. Giant Swarm vintage Azure clusters are using AzureMachine only as a very basic control plane CR, so they are not affected by this change.
@@ -38,6 +38,13 @@ | |||
acceleratedNetworking: | |||
description: AcceleratedNetworking enables or disables Azure accelerated networking. If omitted, it will be set based on whether the requested VMSize supports accelerated networking. If AcceleratedNetworking is set to true with a VMSize that does not support it, Azure will return an error. | |||
type: boolean | |||
additionalCapabilities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New optional property. Giant Swarm vintage Azure clusters are not using AzureMachineTemplate CRs, so they are not affected by this change.
@@ -99,6 +99,11 @@ spec: | |||
readOnly: true | |||
serviceAccountName: capz-manager | |||
terminationGracePeriodSeconds: 10 | |||
tolerations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tolerations should be fine.
@@ -9,7 +9,7 @@ transformers: | |||
- webhook-prefix.yaml | |||
|
|||
images: | |||
- name: us.gcr.io/k8s-artifacts-prod/cluster-api-azure/cluster-api-azure-controller | |||
- name: registry.k8s.io/cluster-api-azure/cluster-api-azure-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New container image registry used by upstream projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for CAPI (Clippy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6bc8c21
to
d9e2df4
Compare
Towards https://github.com/giantswarm/giantswarm/issues/24551
This PR is currently on top of
upstream-update-v1.3.2
branch.TODO:
main
after merging Upstream update to v1.3.2 #76Changes
Highlighted upstream changes that can be relevant for vintage workload clusters
Highlighted upstream changes
(with specified upstream cluster-api-provider-azure versions)
v1.4.0
Add support for Ultra Disks as Persistent Volumesv1.4.0
Add support for user-assigned identity as AzureClusterIdentityv1.4.0
Add ComputeGallery field and add community galleries supportv1.4.3
Addnode-role.kubernetes.io/control-plane
toleration to CAPZ manager deployment implemented in this PRUpstream release notes