Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user-assigned identity as AzureClusterIdentity #2371

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Add support for user-assigned identity as AzureClusterIdentity #2371

merged 2 commits into from
Jun 24, 2022

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 8, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1104

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add support for user-assigned identity as AzureClusterIdentity

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2022
@CecileRobertMichon CecileRobertMichon force-pushed the uami-aad-pod-id branch 3 times, most recently from f02e81b to 9f98c3d Compare June 9, 2022 17:57
@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor Author

I0614 18:26:38.289353 1 azurecluster_controller.go:234] controller/azurecluster/controllers.AzureClusterReconciler.reconcileNormal "msg"="AzureCluster reconcile not done: operation type PUT on Azure resource capz-e2e-ld7am2-public-custom-vnet/capz-e2e-c0r7o2-private-azure-bastion is not done. Object will be requeued after 1m20s" "name"="capz-e2e-c0r7o2-private" "namespace"="capz-e2e-ld7am2" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="AzureCluster" "x-ms-correlation-request-id"="9a315f5b-a3a8-4ac8-94b5-905391d3391f"

bastion host timeout

/retest

@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon CecileRobertMichon changed the title [WIP] Add support for user-assigned identity as AzureClusterIdentity Add support for user-assigned identity as AzureClusterIdentity Jun 17, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2022
@CecileRobertMichon
Copy link
Contributor Author

This is ready for review

/assign @mboersma @Jont828

Jont828
Jont828 reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look pretty solid to me, just had a few small things. As far as the YAML templates go, are we just trying to include the user assigned identity in the custom vnet/private cluster e2e test?

docs/book/src/topics/multitenancy.md Show resolved Hide resolved
test/e2e/azure_privatecluster.go Outdated Show resolved Hide resolved
test/e2e/azure_privatecluster.go Outdated Show resolved Hide resolved
test/e2e/azure_privatecluster.go Show resolved Hide resolved
mboersma
mboersma approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, modulo the outstanding comments.

docs/book/src/topics/multitenancy.md Show resolved Hide resolved
test/e2e/azure_privatecluster.go Show resolved Hide resolved
@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e-exp

jackfrancis
jackfrancis approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@jackfrancis
Copy link
Contributor

/retest

1 similar comment
@CecileRobertMichon
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0ecbf62 into kubernetes-sigs:main Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jun 24, 2022
@nprokopic nprokopic mentioned this pull request Dec 18, 2022
Merged
2 tasks
@CecileRobertMichon CecileRobertMichon deleted the uami-aad-pod-id branch February 17, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Jont828 left review comments

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

Assignees

@mboersma mboersma

@jackfrancis jackfrancis

@Jont828 Jont828

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Multi-tenancy within one manager instance using Azure User Assigned Identities
5 participants
@CecileRobertMichon @jackfrancis @k8s-ci-robot @mboersma @Jont828