Backport changes for bootstrap config reference rotation into v1.4.x branch #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-ready object with different name
fiunchinho
approved these changes
Dec 14, 2023
AndiDog
deleted the
machine-pool-bootstrap-config-ref-rotation-based-on-1.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports kubernetes-sigs#9616 (not merged upstream, but close) and kubernetes-sigs#8667 (merged upstream but not part of 1.4.x). This is absolutely required for giantswarm/roadmap#2217 unless we switch to CAPI v1.5.x now.
I had already successfully tested this together with kubernetes-sigs/cluster-api-provider-aws#4619 on a real management+workload cluster.