🐛 Update MachinePool bootstrap dataSecretName when bootstrap config changes #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Jont828
commented
May 15, 2023
k8s-ci-robot
added
size/L
|
/area machinepool |
sbueringer
reviewed
May 23, 2023
Jont828
force-pushed
the
machinepool-bootstrap-rollout
branch
from
1f715ad
to
731f768
Compare
|
lgtm pending #8667 (comment) |
Jont828
force-pushed
the
machinepool-bootstrap-rollout
branch
from
731f768
to
1e4d365
Compare
|
Done |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e943e5373c2629e6dd93ffefe5807dba198d4f06
|
|
Thank you very much! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 19, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nges
What this PR does / why we need it: Update MachinePool bootstrap dataSecretName when bootstrap config changes. Before, we would return early whenever the dataSecretName was set which means there's no way to update it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #6563