Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gorm session store #131

Merged
merged 2 commits into from
Mar 26, 2022
Merged

feat: Add gorm session store #131

merged 2 commits into from
Mar 26, 2022

Conversation

TJM
Copy link
Contributor

@TJM TJM commented Mar 25, 2021

Adds GoRM session store

@TJM
Copy link
Contributor Author

TJM commented Apr 1, 2021

The test is now failing because of the ancient version of Go. It works on 1.13 and higher (although the error on the old ones says 1.14 :-/ ... anyhow I am not sure how to make it so this specific module is only tested on 1.14 or higher, since its a sub-part. Any tips?

@bluescreen10
Copy link

Hi, I'm interested on this feature. How can I help to get this merged in?

@bluescreen10
Copy link

Hey to skip tests on versions lower than 1.13 you can add a build constraint in the test file for example:

gorm/gorm_test.go

// +build go1.13
package gorm
...

@TJM
Copy link
Contributor Author

TJM commented Mar 25, 2022

I rebased to get rid of the conflicts. I was not sure how to resolve the ones in go.sum.... that file is a mess ;) Maybe go mod tidy ? (shrug)

@bluescreen10
Copy link

go mod tidy would certainly clean things up.

@bluescreen10
Copy link

What do you think @appleboy ?

@TJM
Copy link
Contributor Author

TJM commented Mar 25, 2022

@bluescreen10 - I have a line like the following in my go.mod to use my branch...

replace github.com/gin-contrib/sessions => github.com/TJM/sessions v0.0.4-0.20210325232733-5cce4eb28169

@idc77
Copy link

idc77 commented Apr 9, 2022

It's simply gorm not GoRM.
go orm gorm

@TJM TJM changed the title feat: Add GoRM session store feat: Add gorm session store Apr 11, 2022
@TJM
Copy link
Contributor Author

TJM commented Apr 11, 2022

It's simply gorm not GoRM. go orm gorm

I updated the MR title, but it was already merged, so the commit message will live on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants