Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete context.Clear and dependency to gorilla/context #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KeiichiHirobe
Copy link

@KeiichiHirobe KeiichiHirobe commented Mar 19, 2022

defer context.Clear(c.Request) does not make sense now because this library depends on github.com/gorilla/sessions v1.2.0.

So delete defer context.Clear(c.Request) and, go mod tidy to delete dependency to gorilla/context(UPDATE: #131 made a new dependency to github.com/wader/gormstore/v2@v2.0.0, which depends on gorilla context, so gorilla/context still exists in go.sum ).

If version is lower than v1.2.0, we need this code to avoid memory leak.
ref: gorilla/sessions#175

Resolve: #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency of github.com/gorilla/context
1 participant