-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails to build on macOS with disabled cuda #270
Comments
@davydden can you please add the CMakeCache.txt? Thanks! |
sure, here you go CMakeCache.txt |
wait a second, should that be EDIT: supposedly CMake interface changed recently, as @pratikvn documented this as EDIT2: using |
@davydden , thank you for identifying this. Yes, we had to add Disabling So, it seems that you are having an issue with |
thanks 👍
Should not be the case,
Unfortunately that's not an option. I build the whole stack of things, and too many things fail to build with gcc on |
btw, how is
? EDIT: Oh, I see, you have
and in
Still, I would not really call this "issues with std::mutex", it's rather a compiler has some issues with initialization of static variables in this case (no idea why). |
Sorry, I wrote something that was misleading. We use std::mutex within EDIT:
Yes, you are right. |
@davydden You can disable shared libraries with the |
@hartwiganzt @thoasm static gives other issues while building:
|
Interesting, it looks like your shell does not know the add_custom_target(generate_ginkgo_header ALL
COMMAND ${Ginkgo_SOURCE_DIR}/dev_tools/scripts/update_ginkgo_header.sh
WORKING_DIRECTORY ${Ginkgo_SOURCE_DIR}) After removing this part, it should work fine because we have the global header file I also created the issue #272 to tackle this problem, so this temporary solution will no longer necessary. |
unfortunately, that leads to other errors:
|
@davydden OK, now it seems that it does not accept the |
thanks, that allowed me to build |
`gtest` and `gflags` are updated to their latest release. For `RapidJSON`, try to find a correct version as the last release is over two years old and there is a lot of recent pipeline failures. This PR also ensures for our usage RapidJSON that there is no problem with some compilers when building benchmarks (i.e., building Ginkgo with `-DGINKGO_BUILD_BENCHMARKS=ON`). The problem was that on some compilers, no constructor can be recognized for the RapidJSON `GenericValue` object with a parameter of type `std::size_t`. The fix used is to add an explicit version of our main function `add_or_set_member` for `std::size_t` which uses a `static_cast` to `std::uint64_t`. This is related to #270. Associated pull request: #274.
thanks! |
I disable
cuda
but build fails with undefined symbols that suggest the presence of
cuda
:The text was updated successfully, but these errors were encountered: