Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Mac and other shell versions #272

Closed
thoasm opened this issue Mar 18, 2019 · 0 comments
Closed

Better support for Mac and other shell versions #272

thoasm opened this issue Mar 18, 2019 · 0 comments
Assignees
Labels
is:bug Something looks wrong. is:confirmed Someone confirmed this issue. reg:build This is related to the build system.

Comments

@thoasm
Copy link
Member

thoasm commented Mar 18, 2019

Currently, we use the ** expression to search for newly added files inside include/ginkgo/ and for the make-format. However, this limits us to certain versions of bash where the globstar expression** is supported.

We should replace this globstar expression with a more basic version, so we can support MacOS without any issue, and potentially other shell versions as well.

@thoasm thoasm added the reg:build This is related to the build system. label Mar 18, 2019
@thoasm thoasm added this to the Ginkgo 1.0.0 release milestone Mar 18, 2019
@thoasm thoasm self-assigned this Mar 18, 2019
@tcojean tcojean added is:bug Something looks wrong. is:confirmed Someone confirmed this issue. labels Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something looks wrong. is:confirmed Someone confirmed this issue. reg:build This is related to the build system.
Projects
None yet
Development

No branches or pull requests

2 participants