Removed optional behavior (shopt) from scripts

[thoasm]

Removed the need for the following requested features in the scripts dev_tools/scripts/update_ginkgo_header.sh and dev_tools/scripts/add_license.sh:

• extglob (**) by using find instead
• globstar with appropriate arguments for find

Additionally, made sure that commands that are used (like find, sort, ...) are present and do not return an error.
I am not 100% sure if this check is necessary (or if I should also include cat, rm, mv and so on), but I don't think it hurts.

A big difference for add_license.sh is that the working directory is changed to the root ginkgo directory, and the temporary files will be created in dev_tools/scripts instead of inside the build directory. However, we should not have any name-clashes (and the temporary file names are now variables which can be easily altered).

Additionally, now all folders named build and third_party are ignored by add_license.sh, not just these folders inside the top level of the ginkgo folder (I changed that when I saw that it previously affected files in test_install/build on my system).

Performance wise, I ran time ./dev_tools/scripts/add_license.sh with the current status:

real	0m2,927s
user	0m2,957s
sys	0m1,046s

Before the changes (current develop status), it is:

real	0m3,007s
user	0m2,990s
sys	0m1,060s

So, we don't lose performance here.
Results for time ./dev_tools/scripts/update_ginkgo_header.sh with the current status:

real	0m0,055s
user	0m0,048s
sys	0m0,009s

Before:

real	0m0,055s
user	0m0,041s
sys	0m0,017s

So we don't lose performance here either.

TODO:

• Confirm that it works on Mac

Closes #272.

[hartwiganzt]

Seems not to work for me:

Scanning dependencies of target generate_ginkgo_header
Scanning dependencies of target ginkgo_reference_device
Scanning dependencies of target ginkgo_cuda_device
Scanning dependencies of target ginkgo_omp_device
[  0%] Building CXX object core/devices/reference/CMakeFiles/ginkgo_reference_device.dir/dummy.cpp.o
[  1%] Building CXX object core/devices/cuda/CMakeFiles/ginkgo_cuda_device.dir/executor.cpp.o
[  1%] Building CXX object core/devices/omp/CMakeFiles/ginkgo_omp_device.dir/executor.cpp.o
find: -fprint: unknown primary or operator
Exiting due to an error being returned by `find`!
rm: global_includes.hpp.tmp: No such file or directory
make[2]: *** [CMakeFiles/generate_ginkgo_header] Error 1
make[1]: *** [CMakeFiles/generate_ginkgo_header.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  1%] Built target ginkgo_reference_device
[  1%] Built target ginkgo_cuda_device
[  1%] Built target ginkgo_omp_device
make: *** [all] Error 2

[thoasm]

@hartwiganzt Apparently, the -fprint option I was using is not supported on macs, which I did not know. I replaced this parameter with normal redirecting to a file, can you try it again?

[hartwiganzt]

Works now! Thanks!

[thoasm]

Apparently, on Julius' Mac, the add_license.sh does not work (we manually changed the license in one of the files to check if it works) and get the following error multiple times:

grep: repetition-operator operand invalid

The update_ginkgo_header.sh seems to work fine on his system.

[thoasm]

Now it works on Julius's Mac and on my system.
It would be nice if the reviewers could also test it on their systems to confirm that it works properly by just executing dev_tools/scripts/add_license.sh and dev_tools/scripts/update_ginkgo_header.sh. If there is no error message, it should work fine.

[hartwiganzt]

works.

[tcojean]

LGTM