-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed optional behavior (shopt
) from scripts
#280
Conversation
Seems not to work for me:
|
@hartwiganzt Apparently, the |
Works now! Thanks! |
Apparently, on Julius' Mac, the
The |
Now it works on Julius's Mac and on my system. |
works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removed the need for the following requested features in the scripts `dev_tools/scripts/update_ginkgo_header.sh` and `dev_tools/scripts/add_license.sh`: - `extglob` (`**`) by using `find` instead - `globstar` with appropriate arguments for `find` Additionally, made sure that commands that are used (like `find`, `sort`, ...) are present and do not return an error.
d4c025d
to
e7dca08
Compare
`grep -F` prevents interpreting the given string as an expression (treating `*`, `?` specially), which was necessary in the `add_license.sh` because the beacon contains multiple `*`s and `<`. Also added quotations for a `cd` in `update_ginkgo_header.sh`.
e7dca08
to
1a439b9
Compare
Removed the need for the following requested features in the scripts
dev_tools/scripts/update_ginkgo_header.sh
anddev_tools/scripts/add_license.sh
:extglob
(**
) by usingfind
insteadglobstar
with appropriate arguments forfind
Additionally, made sure that commands that are used (like
find
,sort
, ...) are present and do not return an error.I am not 100% sure if this check is necessary (or if I should also include
cat
,rm
,mv
and so on), but I don't think it hurts.A big difference for
add_license.sh
is that the working directory is changed to the root ginkgo directory, and the temporary files will be created indev_tools/scripts
instead of inside the build directory. However, we should not have any name-clashes (and the temporary file names are now variables which can be easily altered).Additionally, now all folders named
build
andthird_party
are ignored byadd_license.sh
, not just these folders inside the top level of the ginkgo folder (I changed that when I saw that it previously affected files intest_install/build
on my system).Performance wise, I ran
time ./dev_tools/scripts/add_license.sh
with the current status:Before the changes (current
develop
status), it is:So, we don't lose performance here.
Results for
time ./dev_tools/scripts/update_ginkgo_header.sh
with the current status:Before:
So we don't lose performance here either.
TODO:
Closes #272.