Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard for sponsors #7064

Merged
merged 16 commits into from
Jul 28, 2020
Merged

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Jul 6, 2020

@zoek1 zoek1 force-pushed the feature/sponsor-dashboard branch from 51796c4 to 0d077ad Compare July 20, 2020 21:28
@zoek1 zoek1 marked this pull request as ready for review July 20, 2020 21:28
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #7064 into master will increase coverage by 0.00%.
The diff coverage is 7.69%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7064   +/-   ##
=======================================
  Coverage   26.27%   26.28%           
=======================================
  Files         301      300    -1     
  Lines       29455    29445   -10     
  Branches     4330     4333    +3     
=======================================
- Hits         7740     7739    -1     
+ Misses      21444    21435    -9     
  Partials      271      271           
Impacted Files Coverage Δ
app/app/urls.py 86.20% <ø> (ø)
app/dashboard/views.py 10.48% <6.12%> (-0.08%) ⬇️
app/dashboard/models.py 48.62% <33.33%> (+0.08%) ⬆️
app/dashboard/router.py 38.87% <0.00%> (-0.49%) ⬇️
...perftools/management/commands/create_page_cache.py 0.00% <0.00%> (ø)
...ng/management/commands/unsubscribe_daily_emails.py
app/dashboard/admin.py 60.59% <0.00%> (+0.15%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c435440...5cab4a0. Read the comment docs.

@frankchen07
Copy link
Contributor

frankchen07 commented Jul 21, 2020

some comments:

  1. I'm not a huge fan of putting a button for the sponsor hack dashboard here, but I guess that's something we can change later on.
    Screen Shot 2020-07-21 at 12 25 18

  2. What is this from?
    Screen Shot 2020-07-21 at 12 25 29

  3. There's ALOT of information on this page. The density is pretty high. I would move the "view prize" as just a clickable prize name -> takes them to the prize if they desire.
    Screen Shot 2020-07-21 at 12 25 48

  4. Again, awesome to see this happening, there's just alot of text on the page, and there's probably a way to make it stand out better.
    Screen Shot 2020-07-21 at 12 26 17

  5. I don't know where this goes, but there has been conversation about how "finding more hackers" is the value of our network and our product. Sponsors shouldn't even have to touch "finding people", unless it is a means to having a conversation with someone and creating a relationship. That's a different "finding" action.
    Screen Shot 2020-07-21 at 12 26 40

cc @willsputra & @PixelantDesign for what you guys think design-wise.

@zoek1
Copy link
Contributor Author

zoek1 commented Jul 21, 2020

  1. it was deleted in most recent update
  2. I made the changes for this in most recent version
  3. This was implemented request by @PixelantDesign yesterday
    image
  4. Goes to the user directoy

@PixelantDesign
Copy link
Contributor

last change @zoek1 could we make the switch blue color - same as chat icon color?

@danlipert danlipert merged commit 58d6daa into gitcoinco:master Jul 28, 2020
<div>
<span v-if="!isMobileDevice" class="font-body font-weight-semibold">[[ prize.total_submitted ]]/[[prize.total_projects]] Submitted</span>
<span v-if="prize.paid" class="ml-5 font-body font-weight-semibold gc-text-green"><span class="fas fa-check"></span> Paid</span>
<a v-if="!prize.paid" :href="`/issue/payout?pk=${prize.pk}`" class="ml-5 font-body font-weight-semibold">Unpaid</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoek1 @PixelantDesign This is where it was added in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants