YAML grammar files #3079
Merged
YAML grammar files #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sublime Text YAML syntax definitions use the .sublime-syntax file extension Most syntax files declare a YAML 1.2 syntax although they are YAML 1.1 compatible Thus, the YAML version header is stripped off before parsing Displays a warning if parsing fails In .sublime-syntax files, the scope is under the 'scope' key -- as opposed to the usual 'scopeName' key
| @@ -42,7 +42,7 @@ class DirectoryPackage | |||
| case File.extname(path.downcase) | |||
| when '.plist' | |||
| path.split('/')[-2] == 'Syntaxes' | |||
| when '.tmlanguage' | |||
| when '.tmlanguage', '.yaml-tmlanguage', '.sublime-syntax' | |||
There was a problem hiding this comment.
Sublime Text YAML syntax definitions use the .YAML-tmLanguage file extension, and more recently, .sublime-syntax.
|
/ cc @aroben incase he has a chance to give this a quick look. |
GitHub uses the JSON files this script creates rather than parsing the original files directly. So if this script can turn YAML into JSON then it should work fine on GitHub. |
|
This seems reasonable to me 👍 |
|
@arfon Do you want to wait for a specific version to merge this or should I go ahead? |
Nah, let's get this merged in. |
This was referenced Sep 13, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially fixes the issue at #3070.
The scopes for
vendor/grammars/NSISandvendor/grammars/awk-sublimewere not recognized because the Sublime Text XML files were recently removed. The authors only kept the YAML files from which the XML files are generated.Thus, this pull request adds support for YAML syntax definitions in
script/convert-grammars.A few new scopes were detected via
.YAML-tmLanguagefiles. I added them ingrammars.yml.