Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3070 by locking the version of the three grammars in forks:
For all three grammars, the issue is that the authors removed one of the files we were using for parsing (usually
.tmLanguages
files).#3079 should have fixed the issue with two of the three grammars. It allows
convert-grammars
to parse YAML files. It unfortunately does not work (see.nsi
files and.awk
files). I'll open another issue to explain why I think it fails and possible solutions.On the shorter term, I think the best would be to lock the versions.