Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4DForm as a JSON language #4639

Closed
wants to merge 4 commits into from
Closed

Conversation

Ganbin
Copy link

@Ganbin Ganbin commented Sep 4, 2019

Description

4DForm extension contains JSON data representing 4D Form description. It is used in the context of 4D software application which start to provide source control compatibility in beta within the new v17 R6 version and will be released officially in v18 (between end 19 - begin 20). More and more repositories contains that kind of files.

Checklist:

  • I am associating a language with a new file extension.

Gabriel Inzirillo added 3 commits September 4, 2019 14:30
4DForm extension contains a description in JSON format of a form in the 4D software language.
4DForm extension contain JSON data.
This example is a real form used as a demonstration during a 4D training.
form.4DForm will be the most common file name when using 4DForm extension as this is automatically created by the 4D Software.
@stale
Copy link

stale bot commented Oct 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Oct 4, 2019
@lildude lildude removed the Stale label Oct 4, 2019
Alhadis
Alhadis previously approved these changes Oct 4, 2019
@@ -2337,6 +2338,7 @@ JSON:
- ".tern-project"
- ".watchmanconfig"
- composer.lock
- form.4DForm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary as you already added .4DForm as a JSON extension.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I was not sure If I had to add it in the filename too.

.4DForm is already a JSON extension
@Ganbin Ganbin requested a review from pchaigno October 4, 2019 15:03
@pchaigno
Copy link
Contributor

pchaigno commented Oct 4, 2019

@Alhadis Did you already check usage? Each repository seems to hold a lot of files.

@Alhadis
Copy link
Collaborator

Alhadis commented Oct 4, 2019

Crap, you're right. There are only 28 repositories:

abachler/SchoolTrack-TNV
AchimPeschke/ap1
AchimPeschke/ap2
AJARProject/AJ_Tools_UnitTest
Anass093/myREP
august8/4d-version-test
ayoub-kl/4D_git_tuto
Demo4DSummit/4D-Library-Project
Demo4DSummit/testShareProject
Developer34D/4DLibrary
JeanL4D/4DPROJECT
minzirillo/JVFloatingLabel
miyako/4d-plugin-capture-with-preview
miyako/4d-plugin-input-scope
miyako/4d-plugin-tab-ui
miyako/4d-plugin-window-control-v2
robertbroussard/cms
robertbroussard/TimeBase
ThomasMaul/AdminWindow
ThomasMaul/Tools_TM
ThomasMaul/UserMode_Component
ttestd3/DWTestRep
vtalbot4D/4D-Library-Project
vtalbot4D/4DLibraryProject
vtalbot4D/testProject
Westworld/StrukturExport
Westworld/Video
wtaylor-4d/4D_FOR_IOS_DEMOS

Not nearly enough...

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ganbin There isn't enough in-the-wild usage to support this extension yet, as per our contribution guidelines. Since there will be a first, non-beta release soon, we may expect usage to increase (?). In that case, I can add it to #4219 and monitor usage.

@Ganbin
Copy link
Author

Ganbin commented Oct 7, 2019

Hi, thanks for the interest and the check. Effectively, the non-beta (v18) should be released in early 2020. We could expect an increasing number of directories in the mid-2020. I also think that a lot of repositories may be private and are therefore not measurable.

@stale
Copy link

stale bot commented Nov 6, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Nov 6, 2019
@pchaigno
Copy link
Contributor

pchaigno commented Nov 6, 2019

@Ganbin I usually check usage every ~6 months and stop monitoring file extensions for which usage hasn't grown. So it's maybe best if I start checking around the time the non-beta is released... Could you post here when that happens?

@stale stale bot removed the Stale label Nov 6, 2019
@Ganbin
Copy link
Author

Ganbin commented Nov 6, 2019

@pchaigno Ok I will try to remember to post here in about 6 month when the non-beta will be released.

@stale
Copy link

stale bot commented Dec 6, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Dec 6, 2019
@stale
Copy link

stale bot commented Dec 20, 2019

This pull request has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.

@stale stale bot closed this Dec 20, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants