Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4DProject and 4DForm extensions to JSON #4802

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

vdelachaux
Copy link
Contributor

@vdelachaux vdelachaux commented Feb 22, 2020

Description

I would like to add, to complete the 4D programming language, specific extensions, linked to JSON, for the other files used into 4D projects repositories.

Checklist:

@vdelachaux vdelachaux marked this pull request as ready for review March 2, 2020 15:31
@Ganbin
Copy link

Ganbin commented Mar 2, 2020

This pull request is more complete than the old one I have made in September 2019 (#4639) as it contains 3 more extensions that are related to 4D Projects.

@pchaigno Can you do another monitoring to see if we get an evolution since the release of the v18 is officially out since January 2018.

@stale
Copy link

stale bot commented Apr 3, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Apr 3, 2020
@vdelachaux
Copy link
Contributor Author

Please could you make a review ?
Thank you for your help.
Vincent

@stale stale bot removed the Stale label Apr 3, 2020
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay here @vdelachaux 🙇‍♂️

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
@vdelachaux
Copy link
Contributor Author

I hope you are safe and understand the delay 😷

@pchaigno
Copy link
Contributor

pchaigno commented Apr 4, 2020

I've just finished counting repositories for the .4DForm extension with Harvester and despite the 1,928 files, it's actually only 80 repositories by 26 users. I'll continue monitoring usage for that extension at #4219.

@pchaigno pchaigno self-assigned this Apr 4, 2020
@Nixinova
Copy link
Contributor

4DForm by itself should be good to go under the new requirements in #5756. the other extensions should be removed.

@lildude lildude requested a review from a team as a code owner June 8, 2022 09:31
@lildude
Copy link
Member

lildude commented Jun 8, 2022

I've cleaned up and finish off this PR now. I've removed the XML entries as the files are already correctly identified as XML so nothing needs to be done.

I've added samples and update the OP to reflect this.

@lildude lildude changed the title Maps "4D..." extensions to JSON & XML Add 4DProject and 4DForm extensions to JSON Jun 8, 2022
@lildude lildude dismissed pchaigno’s stale review June 8, 2022 10:40

No longer relevant

@lildude lildude merged commit c70d6ce into github-linguist:master Jun 8, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants