-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for more Apex language file extensions (apxc, apxt) #4640
Conversation
Support the main extensions ".apxc" and ".apxt" for apex code.
New sample files with extensions, and code, updated and with reference to web salesforce.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
Please see my comments below. Could also you fill in the license of sample files in the template and update the source links to the samples' original repositories?
For other reviewers: I have downloaded the 1528 .apxc
files and counted 487 repositories by 385 users.
@@ -272,6 +272,8 @@ ApacheConf: | |||
Apex: | |||
type: programming | |||
extensions: | |||
- ".apxc" | |||
- ".apxt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the 221 files associated with that extension using Harvester and counted 106 repositories by 96 users. This is not enough to mandate addition to Linguist by our standards (i.e., hundreds of repositories). I think we should remove it from this pull request and reconsider it in the future if usage grows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is a low number of repositories, but it is the official extension of that language. Users who are using the java extension .cls, is because they want them indexed with linguist, but I'm sure they want to send a pull like this or they don't know how. I really think this would help a lot. Thanks for considering this.
https://trailhead.salesforce.com/en/content/learn/modules/developer_console/developer_console_source_code
https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_intro.htm
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
Any update? Thank you |
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
Nothing about this? please check. Thank u |
All the action is on you right now 😁. #4640 (review) still hasn't been addressed. We need to know precisely where all the samples have come from and the licenses they're covered by for legal reasons. #4640 (comment) also requires action from you. The I've not checked the As Linguist already knows about Apex, users can still use an override for the |
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
This pull request has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue. |
Description
Add the principals extensions ".apxc" and "apxt" for the actual apex language.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language