Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more Apex language file extensions (apxc, apxt) #4640

Closed
wants to merge 2 commits into from

Conversation

Arv18
Copy link

@Arv18 Arv18 commented Sep 5, 2019

Description

Add the principals extensions ".apxc" and "apxt" for the actual apex language.

Checklist:

Support the main extensions ".apxc" and ".apxt" for apex code.
New sample files with extensions, and code, updated and with reference to web salesforce.com.
@Arv18 Arv18 changed the title Support for the main Apex file extensions (apxc, apxt) Support for more Apex language file extensions (apxc, apxt) Sep 5, 2019
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Please see my comments below. Could also you fill in the license of sample files in the template and update the source links to the samples' original repositories?

For other reviewers: I have downloaded the 1528 .apxc files and counted 487 repositories by 385 users.

lib/linguist/languages.yml Show resolved Hide resolved
@@ -272,6 +272,8 @@ ApacheConf:
Apex:
type: programming
extensions:
- ".apxc"
- ".apxt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded the 221 files associated with that extension using Harvester and counted 106 repositories by 96 users. This is not enough to mandate addition to Linguist by our standards (i.e., hundreds of repositories). I think we should remove it from this pull request and reconsider it in the future if usage grows.

Copy link
Author

@Arv18 Arv18 Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is a low number of repositories, but it is the official extension of that language. Users who are using the java extension .cls, is because they want them indexed with linguist, but I'm sure they want to send a pull like this or they don't know how. I really think this would help a lot. Thanks for considering this.

https://trailhead.salesforce.com/en/content/learn/modules/developer_console/developer_console_source_code
https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_intro.htm

@stale
Copy link

stale bot commented Oct 15, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added Stale and removed Stale labels Oct 15, 2019
@stale
Copy link

stale bot commented Nov 14, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Nov 14, 2019
@stale stale bot removed the Stale label Nov 28, 2019
@Arv18
Copy link
Author

Arv18 commented Nov 28, 2019

Any update? Thank you

@stale
Copy link

stale bot commented Dec 28, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Dec 28, 2019
@Arv18
Copy link
Author

Arv18 commented Dec 31, 2019

Nothing about this? please check. Thank u

@stale stale bot removed the Stale label Dec 31, 2019
@lildude
Copy link
Member

lildude commented Jan 3, 2020

Nothing about this? please check. Thank u

All the action is on you right now 😁.

#4640 (review) still hasn't been addressed. We need to know precisely where all the samples have come from and the licenses they're covered by for legal reasons.

#4640 (comment) also requires action from you. The .apxt usage is still too low. It doesn't matter if it's a default or official extension, it still needs to meet the minimum popularity requirement to be added. Accordingly the extension needs to be removed from this PR.

I've not checked the .apxc extension, but assume as @pchaigno didn't explicitly call it out, he has.

As Linguist already knows about Apex, users can still use an override for the .apxt (and .apxc) extension if they really want those file to be correctly identified.

@stale
Copy link

stale bot commented Feb 2, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Feb 2, 2020
@stale
Copy link

stale bot commented Feb 16, 2020

This pull request has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.

@stale stale bot closed this Feb 16, 2020
@Arv18 Arv18 mentioned this pull request Jun 28, 2023
4 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants