-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grammar for Apex #6198
Add grammar for Apex #6198
Conversation
Waiting for forcedotcom/apex-tmLanguage#54 to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that you've manually updated files rather than following the instructions in the CONTRIBUTING.md file and using the supplied scripts. Please don't.
Please use the scripts provided in this repo to change the grammar source.
See my inline comments for the two extensions you're adding.
If in doubt, or for an easy life, don't add these extensions in this PR and leave it purely as a grammar source change PR. Users can implement an override for these files if they feel heavily wed to getting syntax highlighting.
@lildude Anything to change on my end for the tests? |
Yup. The order of the submodules:
This stems from you manually doing things rather than using the scripts (the sorting happens at the end of the You can run |
Got it. Weird, b/c I undid my changes and then ran the scripts. On it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
I understand that adding the extensions, like in an old pull request #4640 are now not necessary. |
@Arv18 If they meet our usage requirements, they can be added. You abandoned the last PR so it was closed (when we still used the stale bot). Feel free to open a new PR and be sure to follow the details in the CONTRIBUTING.md file and fill in the template. Keep in mind, like that last PR, the new PR will not be merged until the usage of the new extensions meets our usage requirements. Until then, you can use an override. |
Description
This PR changes the association of Salesforce's Apex language from
source.java
tosource.apex
. That includes a switch from using Java language definitions to the official tmLanguage definition here.Checklist:
I am associating a language with a new file extension.
I am changing the source of a syntax highlighting grammar