-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WebAssembly Interface Types #6376
Add support for WebAssembly Interface Types #6376
Conversation
Add support for WebAssembly Interface Type (WIT): https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first grammar I've encountered that uses repository
fields in contexts that aren't the top-level grammar object. I see that VSCode supports this, but Atom doesn't—and by extension, that (probably) includes PrettyLights (GitHub's implementation of TextMate's highlighting system, which is closed-source).
So comments will end up looking something like this on GitHub:
This can be solved by moving every named rule to the top-level repository
object.
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
The repository fields have been moved to the top-level object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aa7da15
to
0d905cd
Compare
@Alhadis, I believe the license needs to be reviewed. It should be straightforward because it is Apache 2.0 with LLVM exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Description
Add support for WebAssembly Interface Type (WIT):
https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md
Checklist:
#6250e7