-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aleo and Leo language support #6551
Add Aleo and Leo language support #6551
Conversation
Change color for Leo to #6814ec
For greater consistency with other entries, change color to include uppercase only.
Hey there @lildude, just a friendly ping here to let you know this is ready for review. If you have any questions for us regarding Aleo or Leo, please don't hesitate to reach out. Best wishes for a wonderful start to your week and happy Monday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several issues here:
- your grammars are not Textmate compatible so won't work. This would have been pointed out by a message along the lines of "no grammars found" when you ran the
script/add-grammar
script as detailed in the CONTRIBUTING.md file - your grammar repo doesn't have a license. We can not accept grammars not licensed by one of the documented licenses
- One is your samples is too big - if it's suppressed in the diff, it's too big
- Several of your samples don't appear to be examples of real-world usage.
Beyond the things in your direct control, neither extension is popular enough for inclusion when we exclude forks and the AleoHQ user (this user has an disproportionate influence on the current usage, hence I excluded it)
Oh yes, and we need to know the licence of all samples (they need to be covered by an open source licence)… the repo you referenced has no licence so we can't accept those samples. |
Remove previous grammars.
Too large.
Fix whitespace.
Hey @lildude, Thank you for the prompt response and your feedback. I believe we have sorted out all your previous comments, I've addressed them below. Points 1-4 and 5:
On your point regarding popularity:
Thank you for your consideration 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not accept this grammar as it is licensed under the GPL-3 license. We only accept grammar with these licenses as pointed out in the CONTRIBUTING.md file.
The popularity requirement and method used to determine it still stands and is applied consistently across all contributions.
Hello again @lildude, No problem. I have updated our grammar license to Apache 2.0. Regarding popularity, that's unfortunate to hear, but we understand. I do have a few questions on my end, if that's okay:
Criterion:
Once I've heard back from you, I will work with our teams internally to come up with a strategy to get those numbers up so we can get this merged. In any case, best wishes for a great rest of your evening and an even better Friday + weekend 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-add the grammar using script/add-grammar --replace <submodule path> <repo_url>
and add the cached license file that will be downloaded and added to the repo.
From your description, it sounds like the Aleo files will meet the criteria for only 200 unique
Yes, that's where I'll start. I then use discretion to determine if there is a user having a disproportionate influence on the results, like the
Sounds good, but please don't try and game the system, we want organic real usage. Another thing to note, I won't conduct a thorough popularity search until I'm close to making the next release which is when I merge most PRs. See this note for more details. |
Happy Wednesday/Thursday @lildude! I hope things have been well for you since our last chat. We have been working hard to grow both Leo and Aleo instructions numbers over the last few months. From our side, we can see the numbers have grown to 375 Aleo specific files and 1.1k Leo files when using GitHub search given the criteria we discussed before. Could it be that GItHub's indexer is a bit off when using search? I've refreshed the search for the last several weeks and seen the same numbers despite there being steady growth aligned with our marketing and developer relations efforts using our internal dashboard. I have created a version you can view here. On it, you can see there are more than 2k files (we generate these numbers using a custom indexer of GitHub API data). Any thoughts as to why these numbers (GitHub search vs. GitHub API) might be off and when we can expect GitHub search to update? We are hoping to get both Leo and Aleo instructions merged before the New Year. Looking forward to continuing the conversation. Until then, best wishes for a great rest of your morning/afternoon/evening, wherever you are 😄 |
Yes, GitHub search does not index everything. See the search restrictions which is likely to explain the difference. |
Okay, thank you for the clarification @lildude. Following up, if I submit a PR specifically for Aleo Instructions to be merged since those numbers are at 380, would that be approved? Right now, Aleo Instructions are more valuable from a syntax highlighting perspective since many of the larger programs that folks look at on GitHub are written in it. For example, credits.aleo. If that makes sense to you, I'll create a second PR for just Aleo Instructions and leave this PR as is, waiting until Leo numbers reach 2k. |
@lildude This PR is outdated, please feel free to close at your convenience. |
Proposed changes and reference
Add support for Leo and Aleo instructions. Leo is a functional, statically typed programming language, built for writing private applications. Leo is a high-level programming language that compiles down to low-level Aleo Instructions.
References
Description
languages.yml
file. This includes samples of Aleo and Leo programs, a unique ID for each, and their grammars.Checklist:
#154bf9
#6814ec