Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leo #6970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Leo #6970

wants to merge 2 commits into from

Conversation

d0cd
Copy link

@d0cd d0cd commented Jul 26, 2024

This PR adds Linguist support for the Leo progamming language. Leo is a high-level language that allows developers to use zero-knowledge proofs in their applications while abstracting away the cryptographic complexities. Leo programs are compiled into Aleo instructions, which can be executed on the Aleo blockchain.

References

Checklist

@d0cd d0cd requested a review from a team as a code owner July 26, 2024 21:38
@d0cd d0cd mentioned this pull request Jul 26, 2024
5 tasks
@lildude lildude changed the title Add Linguist support for Leo. Add Leo Aug 5, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the cached license file generated by this line in the add-grammar script:

linguist/script/add-grammar

Lines 133 to 134 in 39fd5e9

log 'Caching grammar license'
bundle exec licensed cache -c vendor/licenses/config.yml

Please add it.

@d0cd d0cd requested a review from lildude August 6, 2024 18:15
@lildude
Copy link
Member

lildude commented Aug 14, 2024

The extension of the new language is used in hundreds of repositories on github.com. https://github.com/search?q=path%3A*main.leo+NOT+owner%3AProvableHQ++NOT+owner%3AAleoNet+NOT+is%3Afork&type=code&p=3. Note that the main.leo file is expected to occur once per repository, which meets the requirements outlined #5756.

This PR is not adding support for a single file, it's adding support for an extension which means the extension criteria applies and as with #6969, it appears quite common for a repo to contain multiple .leo files.

It seems quite common for .leo files to mention aleo so adding that to filter out files which clearly aren't Leo (there are a lot of XML files using this extension) indicates things are nearly there.

@DecimalTurn
Copy link
Contributor

Closes #6900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants