New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling issue on down and up arrow keys #91

Open

thetutlage opened this issue Jun 30, 2022 · 0 comments

thetutlage commented Jun 30, 2022

I see there was an issue related to this back in 2019. However, I still face issue with a scrolling container.

I have attached a recording for the same. When I press the down arrow, the contain scrolls too much that the selected item gets hidden

scroll-issue.mov

seanpdoyle added a commit to seanpdoyle/combobox-nav that referenced this issue


          Use Element.scrollIntoView

f889842

Related to [@github/auto-complete-element#91][]

The current `scrollTo` helper method implementation can be unreliable
(or have no effect) at times.

This commit replaces it with a call to [Element.scrollIntoView][]. To
control that behavior, this commit also introduces a
`scrollIntoViewOptions:` key to the package's constructor call.

[@github/auto-complete-element]#91: github/auto-complete-element#91
[Element.scrollIntoView]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
[ScrollIntoViewOptions]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView#sect1

seanpdoyle mentioned this issue

Use Element.scrollIntoView github/combobox-nav#75

Merged

seanpdoyle added a commit to seanpdoyle/combobox-nav that referenced this issue


          Use Element.scrollIntoView

b0dec8e

Related to [@github/auto-complete-element#91][]

The current `scrollTo` helper method implementation can be unreliable
(or have no effect) at times.

This commit replaces it with a call to [Element.scrollIntoView][]. To
control that behavior, this commit also introduces a
`scrollIntoViewOptions:` key to the package's constructor call.

[@github/auto-complete-element#91]: github/auto-complete-element#91
[Element.scrollIntoView]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
[ScrollIntoViewOptions]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView#sect1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment