Use Element.scrollIntoView

[seanpdoyle]

Related to @github/auto-complete-element#91

The current scrollTo helper method implementation can be unreliable (or have no effect) at times.

This commit replaces it with a call to Element.scrollIntoView. To control that behavior, this commit also introduces a scrollIntoViewOptions: key to the package's constructor call.

[seanpdoyle]

@keithamus I did a preliminary search for attempts to replace the scrollTo implementation with calls to Element.scrollIntoView, but came up empty:

~/Work/github/combobox-nav main
❯ git log -SscrollIntoView

A quick dive into git blame yielded a commit that copied the scrollTo implementation from github/auto-complete-element. A search for scrollIntoView on that project didn't yield any results.

Has this been attempted in the past?

[primer-css]

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.

• 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
• ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
• ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

[broccolinisoup]

@keithamus is this something you can take on to answer or do you prefer for me to look as a FR?

[keithamus]

I’ll take a look thanks @broccolinisoup

[nicowenterodt]

The use of Element.scrollIntoView is really helpful. I checked this and it works wonderful especially if you need to control the scroll position and behavior of it as easy as defining an option like this element.scrollIntoView({ behavior: "smooth", block: "end", inline: "nearest" });

Thanks @seanpdoyle 👏

I would love to see this one merged @keithamus.

[keithamus]

I agree I just want to check some internal codebases to double check if there are any blockers before we merge. I'm a little short on time this week so I'll most likely get to this next week.

[keithamus]

macos build failing for some reason. I'll figure that out separately.