Downgrade @github/combobox-nav #28541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The v2.3.0 update caused to always scroll to the suggestion menu, where it previously wouldn't work at all or only scroll when it wasn't in the viewport. - Ref: github/text-expander-element#50 - Ref: github/combobox-nav#75 - Resolves https://codeberg.org/forgejo/forgejo/issues/1990 (cherry picked from commit 27145be211ff782afe0910adbe200f126961f150)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
approved these changes
Dec 19, 2023
GiteaBot
added
lgtm/need 1
|
Did someone look into providing a reproduction to upstream as requested in github/text-expander-element#50? |
|
For reference: this PR is closed because upstream has a correct fix, so no need to downgrade. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element.scrollIntoViewgithub/combobox-nav#75(cherry picked from commit 27145be211ff782afe0910adbe200f126961f150)