Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Element.scrollIntoView #75

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Use Element.scrollIntoView #75

merged 3 commits into from
Sep 25, 2023

Commits on Sep 5, 2023

  1. Use Element.scrollIntoView 

    Related to [@github/auto-complete-element#91][]

The current `scrollTo` helper method implementation can be unreliable
(or have no effect) at times.

This commit replaces it with a call to [Element.scrollIntoView][]. To
control that behavior, this commit also introduces a
`scrollIntoViewOptions:` key to the package's constructor call.

[@github/auto-complete-element#91]: github/auto-complete-element#91
[Element.scrollIntoView]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
[ScrollIntoViewOptions]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView#sect1
    @seanpdoyle
    seanpdoyle committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b0dec8e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'main' into scroll-into-view

    @keithamus
    keithamus authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    369bf75 View commit details
    Browse the repository at this point in the history

  2. remove code from merge conflict

    @keithamus
    keithamus authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6b9d754 View commit details
    Browse the repository at this point in the history