Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for TRAP caching #1182

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

edoardopirovano
Copy link
Contributor

This PR adds some telemetry for TRAP caching including the times and sizes of the cache uploads/downloads and the languages that we are using TRAP caching for. Almost all of the code change is adding a dependency that computes the recursive size of folders. This is a little jarring, but is I think simpler than writing that code ourselves which is potentially somewhat awkward. I'm definitely open to other suggestions on if there's a simpler way to get the size of the cache, though.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 15, 2022 15:58
@edoardopirovano
Copy link
Contributor Author

Changing to draft as we need a difference dependency with a more open license.

@edoardopirovano edoardopirovano added the Update dependencies Trigger PR workflow to update dependencies label Aug 16, 2022
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Aug 16, 2022
@edoardopirovano edoardopirovano added the Update dependencies Trigger PR workflow to update dependencies label Aug 16, 2022
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Aug 16, 2022
@edoardopirovano
Copy link
Contributor Author

This is now ready for review again.

src/init-action.ts Outdated Show resolved Hide resolved
src/config-utils.ts Show resolved Hide resolved
src/config-utils.ts Outdated Show resolved Hide resolved
src/analyze-action.ts Outdated Show resolved Hide resolved
src/analyze-action.ts Outdated Show resolved Hide resolved
src/analyze-action.ts Outdated Show resolved Hide resolved
src/trap-caching.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment around the get-folder-size package, otherwise LGTM.

package.json Show resolved Hide resolved
src/trap-caching.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants