Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use util.promisify instead of manually constructing promise #1184

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Use util.promisify instead of manually constructing promise #1184

merged 1 commit into from
Aug 16, 2022

Conversation

edoardopirovano
Copy link
Contributor

Addresses a minor follow-up comment from @henrymercer in #1182.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 16, 2022 13:44
henrymercer
henrymercer approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@edoardopirovano edoardopirovano merged commit b0d61cf into main Aug 16, 2022
@edoardopirovano edoardopirovano deleted the edoardo/trap-telemetry-followup branch August 16, 2022 14:48
This was referenced Aug 17, 2022
Closed
Merged
Merged
This was referenced Apr 25, 2023
Open
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoardopirovano @henrymercer