-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby and Swift language autodetect test #1369
Conversation
🤔 Hmm, I think Swift can only be auto-detected in the CLI as of |
I thought so too, but was surprised that it passed in a previous run (before I marked ready for review and merged I can make this repo draft until 2.11.4 is released (so it would be caught under |
# This check should be combined into `multi-language-autodetect.yml` once Swift is GA'ed | ||
# and the `CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT` environment variable is not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine to set CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true
in multi-language-autodetect.yml
to help cut down on the number of jobs. We could add some checks on the tools version to make sure that language autodetection does the right thing for old CLIs too.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
if: (matrix.version == 'cached' || matrix.version == 'latest' || matrix.version | ||
== 'nightly-latest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is what you'd meant by using the tools version, but I saw there was precedent for using the matrix.version
in the ml-powered-queries
PR check.
Currently, just checking Ruby and Swift in the most recent 3 CLIs and the other languages in the hardcoded 3 prior CLIs. This can be made more robust when we work out our testing plan for all supported releases.
Ah, I am having some errors come up in
will have to re-run these checks when the version in |
This PR check adds Swift and Ruby to the existing multi-language autodetect check. Once Swift is in GA, we will be able to remove the
CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT: "true"
set in that check.Merge / deployment checklist