-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into releases/v2 #1395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to set it automatically in the workflow generator, simplifying things and reducing the scope for error.
TRAP Caching: Re-introduce workaround for download timeout
…ment Set testing environment for CodeQL workflow
Mergeback v2.1.33 refs/heads/releases/v2 into main
Add Ruby to README
This will allow feature flags to be shared across steps in the same job, avoiding an error we saw earlier where the init action had the flag enabled, but the analyze step had it disabled. This uses the runner's temp folder to cache the flags file, which will stick around until the job completes.
Cache feature flags on disk
The expected deprecation date of GHES 3.3 has been postponed, so v1 will now be deprecated in January.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
The version installed in the latest runner image, 5.7.1, is not yet supported.
Use Swift version 5.7 in PR checks
…n-date Update v1 deprecation date
…er-versions Update supported GitHub Enterprise Server versions.
Remove some dead code
Currently only macOS supports 5.7.1
This works by moving the logic to check for toolcache bypass out of creating the codeql instance. The logic now _may_ perform an API request in order to check what languages are in the repository. This check is redundant because the same call is being made later in the action when the actual list of languages is calculated.
Update default CodeQL bundle version to 2.11.4
…o-5.7.1 Run Swift tests with Swift 5.7.1 on macOS
If a user explicitly includes java in their language inputs, always make an api call to check for kotlin in the repo. Also, add some suggestions from code reviews.
…in-swift Add a way to bypass the toolcache for kotlin and swift
This just needs an approval to merge. |
henrymercer
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 7e73ded into releases/v2
Conductor for this PR is @alexet.
Contains the following pull requests:
Please do the following:
Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.