Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #869 from github/edoardo/windows-11-error" #948

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

edoardopirovano
Copy link
Contributor

This reverts commit faa9ba7, reversing changes made to 71112ab.

The last few versions of the CodeQL CLI have emitted errors about tracing incompatibility with Windows 11, so there is no need for the Action to continue to emit these. In addition, the CodeQL CLI will soon be compatible with Windows 11, so if we still had the error here in place when that happens we would be stopping users from using CodeQL on Windows 11 for no good reason.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner February 24, 2022 11:33
Copy link
Contributor

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side (but I'm not an actions reviewer, so maybe get a review from them, too)

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we continue to raise errors for users using old versions of CodeQL with build tracing that's incompatible with Windows 11?

@criemen
Copy link
Contributor

criemen commented Feb 24, 2022

I thought about this, but I don't think it's necessary:
These users would have to pin an old version of the CLI in their workflow, but use the codeql-action from v1/main. I think that's sufficiently uncommon to not keep this code around, as it's pure tech debt for us.
Especially as the code is relying on a hand-written list of which languages are traced and which are not, without querying the CLI.

@edoardopirovano
Copy link
Contributor Author

I'm inclined to agree. We already have so many version flags in the Action, if we can avoid adding another one that seems preferable.

@henrymercer
Copy link
Contributor

Makes sense 👍

@edoardopirovano edoardopirovano merged commit 438f654 into main Feb 24, 2022
@edoardopirovano edoardopirovano deleted the edoardo/revert-windows-11 branch February 24, 2022 14:36
@github-actions github-actions bot mentioned this pull request Mar 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants