-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into v1 #965
Merge main into v1 #965
Conversation
Mergeback v1.1.3 refs/heads/v1 into main
Revert "Merge pull request #869 from github/edoardo/windows-11-error"
Bumps [removeNPMAbsolutePaths](https://github.com/juanjoDiaz/removeNPMAbsolutePaths) from 2.0.0 to 3.0.0. - [Release notes](https://github.com/juanjoDiaz/removeNPMAbsolutePaths/releases) - [Commits](juanjoDiaz/removeNPMAbsolutePaths@v2.0.0...v3.0.0) --- updated-dependencies: - dependency-name: removeNPMAbsolutePaths dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…AbsolutePaths-3.0.0 Bump removeNPMAbsolutePaths from 2.0.0 to 3.0.0
Update default CodeQL bundle version to 2.8.2
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Delete the results directory in between runs.
Expand PR checks to cover `windows-2022`
This reverts commit 326e511.
Second attempt to use `--codescanning-config` flag of CLI
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Bumps [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact) from 0.5.2 to 1.0.0. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/@actions/io@1.0.0/packages/artifact) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…rtifact-1.0.0 Bump @actions/artifact from 0.5.2 to 1.0.0
Add runner OS and arch to status report
Fix link to docs
@edoardopirovano Does #957 need a change note, or is it sufficiently internal? |
Also, #869 should probably have a change note. I think the action was alreade broken on windows 11, this just makes the error message more understandable. Maybe something like:
|
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Is this still relevant? The CLI changelog says it now ought to work on Windows 11.
Edoardo is on vacation this week. We'll have to make a decision in his absence. |
I think since it shouldn't change anything from a user point of view it does not need a change note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this goes in, lgtm.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
CHANGELOG.md
Outdated
|
||
- Update default CodeQL bundle version to 2.8.2. [#950](https://github.com/github/codeql-action/pull/950) | ||
- Fix a bug where old results can be uploaded if the languages in a repository change when using a non-ephemeral self-hosted runner. [#955](https://github.com/github/codeql-action/pull/955) | ||
- Fail with a meaningful error message for Windows 11 and Windows Server 2022 which are currently unsupported. [#869](https://github.com/github/codeql-action/pull/869) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @hmakholm's earlier comment is correct: 2.8.2 introduces support for Windows 11, so we should instead highlight that (or reference the 2.8.2 change notes). @criemen to confirm.
Also if I'm reading the generated PR summary correctly, this mergeback PR does not contain #869; it contains #948 which is the revert of #869.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. My mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm 2.8.2 introduces W11 support.
I don't think this should go in the action changelog, as the action now just delegates to the CLI about W11 supports presence/absence, and that's mainly controlled by what's in the toolcache.
Merging 308528b into v1
Conductor for this PR is @aeisenberg
Contains the following pull requests:
windows-2022
#954 - Expand PR checks to coverwindows-2022
(@edoardopirovano)--codescanning-config
flag of CLI #957 - Second attempt to use--codescanning-config
flag of CLI (@edoardopirovano)Please review the following: