Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node:18 in examples of actions with containers #28442

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Use node:18 in examples of actions with containers #28442

merged 2 commits into from
Sep 25, 2023

Conversation

tvalenta
Copy link
Contributor

@tvalenta tvalenta commented Sep 22, 2023 •
edited
Loading

Why:

Closes: #28440

What's being changed (if available, include any code snippets, screenshots, or gifs):

The image node:14.16 is old, and doesn't work with actions/checkout@v4 which might contribute to issues such as actions/checkout#1474

This change uses node:18 for the example, which is the LTS version of node for one more month.

https://github.com/nodejs/release#release-schedule

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@tvalenta
Use node:18 in examples of actions with containers
1ede3a2 
The image `node:14.16` is old, and doesn't work with
`actions/checkout@v4` which might contribute to issues such as
actions/checkout#1474

This change uses `node:18` for the example, which is the LTS version of
node for one more month.

https://github.com/nodejs/release#release-schedule
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners/customizing-the-containers-used-by-jobs.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Alejandrocontrera

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Contributor

cmwilson21 commented Sep 25, 2023 •
edited
Loading

@tvalenta Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 25, 2023
jc-clark
jc-clark approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this update @tvalenta! ✨

I'll go ahead and help merge this

@jc-clark jc-clark added this pull request to the merge queue Sep 25, 2023
Merged via the queue into github:main with commit 081b38f Sep 25, 2023
41 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@tvalenta tvalenta deleted the update_container_example branch September 25, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-clark jc-clark jc-clark approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples of jobs running in a container reference the old node:14.16 image
4 participants
@tvalenta @Alejandrocontrera @cmwilson21 @jc-clark