Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkout@v4 doesnt work inside container action #1474

Closed
copdips opened this issue Sep 15, 2023 · 2 comments
Closed

checkout@v4 doesnt work inside container action #1474

copdips opened this issue Sep 15, 2023 · 2 comments

Comments

@copdips
Copy link

copdips commented Sep 15, 2023

v4 doesnt work, but it's working for v3.

jobs:
  container-test-job:
    runs-on: ubuntu-latest
    container: node:14.16
    steps:
      - name: Check out repository code
        uses: actions/checkout@v4

Error message:

Run actions/checkout@v4
/usr/bin/docker exec  7cbdf08ca47fe2456a9002981cd5b884c8e98459104cbf71a6412df305a5614c sh -c "cat /etc/*release | grep ^ID"
/__e/node[20](https://github.com/pernod-ricard-coe-data/cicd-test/actions/runs/6198845372/job/16830116625#step:4:21)/bin/node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)
@tvalenta
Copy link

The Docker image for node:14.16 has glibc 2.24, but that version of node has been end-of-lifed. If looks like even node:14 will have a more updated version of glibc.

 > podman run --arch x86_64 -it --rm  node:14 /bin/bash
root@9d7f7b68b108:/# /lib/x86_64-linux-gnu/libc.so.6 -version
GNU C Library (Debian GLIBC 2.28-10+deb10u2) stable release version 2.28.
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
Compiled by GNU CC version 8.3.0.
libc ABIs: UNIQUE IFUNC ABSOLUTE
For bug reporting instructions, please see:
<http://www.debian.org/Bugs/>.

https://github.com/nodejs/release#release-schedule

@copdips
Copy link
Author

copdips commented Sep 20, 2023

@tvalenta
thanks, it's true that node:14 is working with checkout@v4

@copdips copdips closed this as completed Sep 20, 2023
This was referenced Sep 22, 2023
Closed
Merged
@ggarber ggarber mentioned this issue Oct 1, 2023
Merged
AleksanderBobinski added a commit to AleksanderBobinski/workspace-bookmark that referenced this issue Nov 18, 2023
@AleksanderBobinski
.github/workflows/test.yaml: Downgrade checkout-action to v3.6.0
728ae67 
Ubuntu 20.04 is not quite ready for v4 which uses a node version that is
too new for the system.
[1] actions/checkout#1474
AleksanderBobinski added a commit to AleksanderBobinski/workspace-bookmark that referenced this issue Nov 18, 2023
@AleksanderBobinski
.github/workflows/test.yaml: Downgrade checkout-action to v3.6.0
bdcb888 
Ubuntu 20.04 is not quite ready for v4 which uses a node version that is
too new for the system.
[1] actions/checkout#1474
@laverya laverya mentioned this issue Nov 23, 2023
Merged
@hmenke hmenke mentioned this issue Dec 5, 2023
Closed
This was referenced Dec 6, 2023
Closed
Merged
This was referenced Dec 23, 2023
Open
Merged
This was referenced Feb 2, 2024
Merged
Closed
dacort added a commit to dacort/duckdb-athena-extension that referenced this issue Feb 14, 2024
@dacort
checkout@v4 is not compatible with ubuntu:18 actions/checkout#1474
de5f8d1
rurouniken98 added a commit to rurouniken98/pipelinegod that referenced this issue Mar 7, 2024
@rurouniken98
CI: Test checkout@v3
d9ffd86 
Refer to 
actions/checkout#1474
actions/checkout#1487
zanieb added a commit to astral-sh/uv that referenced this issue Mar 12, 2024
@zanieb
Use actions/checkout@v3 to workaround node20 requirement
5d66df1 
- actions/checkout#1487
- actions/checkout#1474
@erick-xanadu erick-xanadu mentioned this issue Apr 25, 2024
Merged
This was referenced Jul 8, 2024
Closed
Merged
loadams added a commit to microsoft/DeepSpeed that referenced this issue Jul 8, 2024
@loadams
Update node16 check on self-hosted runners and remove python 3.6 (#5756)
8411816 
With changes from GitHub [finally
deprecating](actions/checkout#1474) [node16
based
runners](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)
(which the checkout@v3 action uses) we need to make changes to support
this.

To do this, there are two changes. First we remove the python 3.6 check
as with the changes in pydantic v2 that will be merged soon, we will be
removing this check there, so we can more easily remove it now so that
future PRs are cleaner and it is clear why some changes have been made.

Second, node16 is the default on some of our self-hosted runners. To
work around tests failing on these, we [set the GitHub env var to
override this
check](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/).

Other relevant links:
actions/checkout#1474
https://github.com/easybuilders/easybuild-framework/pull/4574/files
actions/checkout#1809
actions/runner#3373
actions/checkout#1809
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this issue Jul 10, 2024
@loadams
Update node16 check on self-hosted runners and remove python 3.6 (mic…
8238a9d 
…rosoft#5756)

With changes from GitHub [finally
deprecating](actions/checkout#1474) [node16
based
runners](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)
(which the checkout@v3 action uses) we need to make changes to support
this.

To do this, there are two changes. First we remove the python 3.6 check
as with the changes in pydantic v2 that will be merged soon, we will be
removing this check there, so we can more easily remove it now so that
future PRs are cleaner and it is clear why some changes have been made.

Second, node16 is the default on some of our self-hosted runners. To
work around tests failing on these, we [set the GitHub env var to
override this
check](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/).

Other relevant links:
actions/checkout#1474
https://github.com/easybuilders/easybuild-framework/pull/4574/files
actions/checkout#1809
actions/runner#3373
actions/checkout#1809
@lexicalunit lexicalunit mentioned this issue Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvalenta @copdips