Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the same build step as the actual release #4157

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

laverya
Copy link
Member

@laverya laverya commented Nov 23, 2023

specifically drop buildkite

What this PR does / why we need it:

The current build fails, because the buildkite image is really, really old.

This is the only place we use the buildkite image - including the prod release process, which the updated version is copied from.

build-web:
runs-on: ubuntu-20.04
needs: [generate-tag]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '17.x'
- name: Build web
env:
GIT_TAG: ${{ needs.generate-tag.outputs.tag }}
run: mapfile -t envs < <(grep -v '#.*' < .image.env) && export "${envs[@]}" && make -C web deps build-kotsadm
- name: Upload web artifact
uses: actions/upload-artifact@v3
with:
name: web
path: ./web/dist

Looks a whole lot like actions/checkout#1474.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?


Does this PR require documentation?

@laverya laverya merged commit 32e9a4d into main Nov 23, 2023
162 checks passed
@laverya laverya deleted the laverya/dont-use-buildkite-image branch November 23, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants