-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in getElementType
logic
#525
Conversation
const defaultComponent = settings.git.luolix.topponents[rawElement] | ||
|
||
// check if the default component is also defined in the configuration | ||
return defaultComponent ? defaultComponent : defaultComponent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intentional @kendallgassner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely not
87a0e9f
to
9deac20
Compare
@@ -15,7 +15,7 @@ | |||
"lint:eslint-docs": "npm run update:eslint-docs -- --check", | |||
"lint:js": "eslint .", | |||
"pretest": "mkdir -p node_modules/ && ln -fs $(pwd) node_modules/", | |||
"test": "npm run eslint-check && npm run lint && mocha tests/**/*.js tests/", | |||
"test": "npm run eslint-check && npm run lint && mocha tests/**/*.js tests/**/*.mjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mjs
tests don't actually seem to be running, since this update. Updating this glob seems to fix it.
import {getElementType} from '../../lib/utils/get-element-type.js' | ||
import {mockJSXAttribute, mockJSXConditionalAttribute, mockJSXOpeningElement} from './mocks.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I need to add the .js
extension, or I run into failure
Exception during run: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/eslint-plugin-github/eslint-plugin-github/lib/utils/get-element-type' imported from /home/runner/work/eslint-plugin-github/eslint-plugin-github/tests/utils/get-element-type.mjs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library seems to be using a mix of module JS and common JS now
I wonder if that's why? 🫤
@github/web-systems-reviewers Node 14 builds seem to be failing. Can we drop support? -- The answer is yes! slack thread! |
@@ -10,6 +10,7 @@ module.exports = { | |||
extends: [require.resolve('./lib/configs/recommended'), 'plugin:eslint-plugin/all'], | |||
plugins: ['eslint-plugin'], | |||
rules: { | |||
'import/extensions': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the JS files to be loaded into .mjs
, we need an extension.
This library seems to be using a mix of module JS and common JS now, so we'll want to turn this rule off.
👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.
|
.github/workflows/nodejs.yml
Outdated
@@ -12,7 +12,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [14, 16, 18] | |||
node-version: [18] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add 20? I've been seeing more Actions migrate to it, and it's now a year old; if nothing breaks might be nice to start testing against it.
(disclaimer: I'm not the expert on node versions.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh okay! let's see what it tells us!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOO! Added, and passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for web-systems-reviewers
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-github](https://github.com/github/eslint-plugin-github) | [`4.10.2` -> `5.0.1`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/eslint-plugin-github (eslint-plugin-github)</summary> ### [`v5.0.1`](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.1) [Compare Source](https://github.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1) #### What's Changed - chore(deps): bump the all-dependencies group with 5 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#530 - Provide `no-redundant-roles` exception for `rowgroup` by [@​khiga8](https://github.com/khiga8) in [github/eslint-plugin-github#531 **Full Changelog**: github/eslint-plugin-github@v5.0.0...v5.0.1 ### [`v5.0.0`](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.0) [Compare Source](https://github.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0) Formally releasing v5.0.0! This release includes everything in pre-release [v5.0.0-2](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)! We notably dropped support for node 14 and node 16 in favor of node 18. #### What's Changed - Drop node 14/16 support and fix bug in `getElementType` logic by [@​khiga8](https://github.com/khiga8) in [github/eslint-plugin-github#525 - Bump node 14 to node 18 by [@​khiga8](https://github.com/khiga8) in [github/eslint-plugin-github#529 - chore(deps): bump the all-dependencies group with 4 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#510 - chore(deps): bump the all-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#511 - chore(deps): bump the all-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#512 - chore(deps): bump the all-dependencies group with 3 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#514 - chore(deps): bump the all-dependencies group across 1 directory with 4 updates by [@​dependabot](https://github.com/dependabot) in [github/eslint-plugin-github#522 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/WtfJoke/setup-groovy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This PR fixes a few issues:
1. Fixing bug in
getElementType
logicwill be interpreted as
div
. Currently the linter will check the mapping if it is unable to interpret the polymorphic value. However, it should not do that because that is not a correct interpretation.2. Fixing mjs tests that aren't running
I noticed the tests in
utils
aren't running even when callingnpm run test
.This seems related to this change where the tests were converted to
.mjs
, but the.mjs
tests aren't actually running. When I fixed the command, the tests are being targeted. The test will not run properly without the.js
extension.3. Drops node 14 support
Drops node 14 support per slack thread!
4. Adds node 16 support