Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node 14 to node 18 in publish workflow #529

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 20, 2024

We recently decided to drop node 14 and 16 support..

I forgot to remove the node version from the publish workflow resulting in publish workflow failure, so this PR drops it and upgrades the version to node 18.

@khiga8 khiga8 requested a review from a team as a code owner May 20, 2024 17:37
@khiga8 khiga8 requested a review from dgreif May 20, 2024 17:37
@khiga8 khiga8 changed the title Drop node 14 in publish workflow Bump node 14 to node 18 in publish workflow May 20, 2024
@dgreif dgreif merged commit 2b8550f into main May 20, 2024
4 checks passed
@dgreif dgreif deleted the kh-drop-14-support branch May 20, 2024 17:47
WtfJoke added a commit to WtfJoke/setup-groovy that referenced this pull request Aug 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-github](https://github.com/github/eslint-plugin-github)
| [`4.10.2` ->
`5.0.1`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>github/eslint-plugin-github (eslint-plugin-github)</summary>

###
[`v5.0.1`](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.1)

[Compare
Source](https://github.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1)

#### What's Changed

- chore(deps): bump the all-dependencies group with 5 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#530
- Provide `no-redundant-roles` exception for `rowgroup` by
[@&#8203;khiga8](https://github.com/khiga8) in
[github/eslint-plugin-github#531

**Full Changelog**:
github/eslint-plugin-github@v5.0.0...v5.0.1

###
[`v5.0.0`](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.0)

[Compare
Source](https://github.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0)

Formally releasing v5.0.0!

This release includes everything in pre-release
[v5.0.0-2](https://github.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)!

We notably dropped support for node 14 and node 16 in favor of node 18.

#### What's Changed

- Drop node 14/16 support and fix bug in `getElementType` logic by
[@&#8203;khiga8](https://github.com/khiga8) in
[github/eslint-plugin-github#525
- Bump node 14 to node 18 by
[@&#8203;khiga8](https://github.com/khiga8) in
[github/eslint-plugin-github#529
- chore(deps): bump the all-dependencies group with 4 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#510
- chore(deps): bump the all-dependencies group with 2 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#511
- chore(deps): bump the all-dependencies group with 2 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#512
- chore(deps): bump the all-dependencies group with 3 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#514
- chore(deps): bump the all-dependencies group across 1 directory with 4
updates by [@&#8203;dependabot](https://github.com/dependabot) in
[github/eslint-plugin-github#522

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/WtfJoke/setup-groovy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants