Update CODEOWNERS, fix lint workflow #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix early 'Set up job' failures: > Error: Unable to resolve action `github/go-linter`, not found Commit sha from https://github.com/golangci/golangci-lint-action/releases/tag/v6.1.1 Workflow setup from https://github.com/github/gh-ost/blob/48cb9ab7c7aea1953b086fb68fff6e2b5dd2f0c1/.github/workflows/golangci-lint.yml
| @@ -1 +1 @@ | |||
| * @github/bento-reviewers | |||
| * @github/github-models-reviewers | |||
There was a problem hiding this comment.
✨ This is awesome!
Are there places in dotcom we should be making this substitution too? Happy to help with it!
There was a problem hiding this comment.
There are! There's a PR in flight now to do so.
Deborah-Digges
approved these changes
Oct 16, 2024
"The action will first check the local cache for a version match. If a version is not found locally, it will pull it from the main branch of the go-versions repository. On miss or failure, it will fall back to downloading directly from go dist. To change the default behavior, please use the check-latest input." - https://github.com/actions/setup-go
cheshire137
force-pushed
the
codeowner-modl-team
branch
from
8b1535f to
dd13a17
Compare
cheshire137
commented
Oct 16, 2024
| - "**.go" | ||
| - go.mod | ||
| - go.sum | ||
| - .github/workflows/lint.yml |
There was a problem hiding this comment.
With these changes, the linter workflow won't run when, say, a Markdown file is edited.
cheshire137
commented
Oct 16, 2024
| strict: true | ||
| go-version: ${{ vars.GOVERSION }} | ||
| goproxy-token: ${{secrets.GOPROXY_TOKEN}} | ||
| uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 |
There was a problem hiding this comment.
Using a different linter since the other was giving errors about "Error: Unable to resolve action github/go-linter, not found".
Deborah-Digges
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loops in a broader group of code reviewers when files in the repo are changed. I also updated the lint workflow because I noticed it was failing in the setup stage with "Error: Unable to resolve action
github/go-linter, not found".